New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839593 link

Starred by 3 users
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Jun 2018
Cc:
r...@chromium.org
█ xiaoyinh@chromium.org
wzang@chromium.org
qnnguyen@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

[Regression] The links on the network error screen are not clickable

Project Member Reported by wzang@chromium.org, May 3 2018 
On views-based login screen, disconnect the network and click "Add Person", the network error screen is shown as expected.

But the two links ("browser as Guest" and "Sign in as existing user") are not clickable. Verified that they work on the web-ui.
Screenshot 2018-05-03 at 2.54.44 PM.png
298 KB View Download

Comment 1 by wzang@chromium.org, May 4 2018

Cc: -jdufault@chromium.org wzang@chromium.org
Labels: ReleaseBlock-Stable
Owner: jdufault@chromium.org
Status: Assigned (was: Available)

Comment 2 by jdufault@chromium.org, Jun 7 2018

Cc: jdufault@chromium.org
Labels: -M-68 M-69
Owner: qnnguyen@chromium.org

Comment 3 by qnnguyen@chromium.org, Jun 8 2018

Cc: qnnguyen@chromium.org
 Issue 810191  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b048769fa41f8f2c0c04f5632d307852318e808b

commit b048769fa41f8f2c0c04f5632d307852318e808b
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Mon Jun 11 23:24:21 2018

Enable guest/offline signin links in views login network error screen.

This CL also disables the LoginScreenLocalePolicyTest.LoginLocaleEnforcedByPolicy
browser test. It seems to be related to a pre-existing bug: crbug/844572

Bug:  839593 
Change-Id: I022bf1603ba54386c3686aebd3868d6dee0cd993
Reviewed-on: https://chromium-review.googlesource.com/1093881
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566197}
[modify] https://crrev.com/b048769fa41f8f2c0c04f5632d307852318e808b/chrome/browser/chromeos/login/login_screen_policy_browsertest.cc
[modify] https://crrev.com/b048769fa41f8f2c0c04f5632d307852318e808b/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/b048769fa41f8f2c0c04f5632d307852318e808b/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/b048769fa41f8f2c0c04f5632d307852318e808b/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/b048769fa41f8f2c0c04f5632d307852318e808b/chrome/browser/chromeos/login/ui/login_display_mojo.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83ce891c704906a68b9ed3ca02a86b4fd2d8a9e7

commit 83ce891c704906a68b9ed3ca02a86b4fd2d8a9e7
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Jun 12 23:47:38 2018

Revert "Enable guest/offline signin links in views login network error screen."

This reverts commit b048769fa41f8f2c0c04f5632d307852318e808b.

Reason for revert: chromium.memory cros msan

Original change's description:
> Enable guest/offline signin links in views login network error screen.
> 
> This CL also disables the LoginScreenLocalePolicyTest.LoginLocaleEnforcedByPolicy
> browser test. It seems to be related to a pre-existing bug: crbug/844572
> 
> Bug:  839593 
> Change-Id: I022bf1603ba54386c3686aebd3868d6dee0cd993
> Reviewed-on: https://chromium-review.googlesource.com/1093881
> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566197}

TBR=jdufault@chromium.org,qnnguyen@chromium.org

Change-Id: I03db3d2a5389bced6efbda91219c020ba4f19c68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  839593 
Reviewed-on: https://chromium-review.googlesource.com/1098275
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566631}
[modify] https://crrev.com/83ce891c704906a68b9ed3ca02a86b4fd2d8a9e7/chrome/browser/chromeos/login/login_screen_policy_browsertest.cc
[modify] https://crrev.com/83ce891c704906a68b9ed3ca02a86b4fd2d8a9e7/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/83ce891c704906a68b9ed3ca02a86b4fd2d8a9e7/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/83ce891c704906a68b9ed3ca02a86b4fd2d8a9e7/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/83ce891c704906a68b9ed3ca02a86b4fd2d8a9e7/chrome/browser/chromeos/login/ui/login_display_mojo.h

Comment 7 by qnnguyen@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment