Specifically need an implementation of ui::mojom::DisplayManager.
James, I'm hoping you can take this on. The ws class that is similar to this is in services/ui/ws/user_display_manager. Hopefully you can make the ws2 version observe Screen directly.
https://chromium-review.googlesource.com/c/chromium/src/+/1050949 Still need to fix one Linux Ozone test, probably it's not providing display::Screen with the expected lifetime.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec1de3888ca741b783153eeee7ae453b7ad49025 commit ec1de3888ca741b783153eeee7ae453b7ad49025 Author: James Cook <jamescook@chromium.org> Date: Wed May 09 22:40:09 2018 cros: Add ws2::DisplayManagerMus This provides ScreenMus with information about display configuration. It is used by the browser when running out-of-process ash ("mash") and by mini-mojo-apps under ash_shell_with_content for development purposes. Next step: Hook up FrameDecorationValues TBR=tsepez@chromium.org BUG= 839592 TEST=services_unittests Change-Id: I281e141e92d7a1a8e82780063f20a4d75fd79d23 Reviewed-on: https://chromium-review.googlesource.com/1050949 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#557350} [modify] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/ash/shell/content/shell_with_content_main.cc [modify] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/public/interfaces/display_manager.mojom [modify] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/ws2/BUILD.gn [add] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/ws2/display_manager_mus.cc [add] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/ws2/display_manager_mus.h [add] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/ws2/display_manager_mus_unittest.cc [modify] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/ws2/window_service.cc [modify] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/ws2/window_service.h [modify] https://crrev.com/ec1de3888ca741b783153eeee7ae453b7ad49025/services/ui/ws2/window_service_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d3e3473631c50f6bac67901fc98c34611905891 commit 7d3e3473631c50f6bac67901fc98c34611905891 Author: James Cook <jamescook@chromium.org> Date: Thu May 10 05:16:16 2018 Rename ui::mojom::DisplayManager to ui::mojom::ScreenProvider It just provides backing for ScreenMus; it doesn't really manage displays (and we already have display::DisplayManager). Rename ui::ws2:DisplayManagerMus to ScreenProvider. Leave ui::ws::UserDisplayManager as-is, since it may go away or get refactored soon. TBR=tsepez@chromium.org for renaming an existing mojom BUG= 839592 TEST=services_unittests and views_mus_unittests Change-Id: I392f8f8c306e1a0b4497cd3ef455464359acbae5 Reviewed-on: https://chromium-review.googlesource.com/1053170 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#557456} [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/manifest.json [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/public/interfaces/BUILD.gn [rename] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/public/interfaces/screen_provider.mojom [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/service.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/service.h [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws/test_utils.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws/test_utils.h [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws/user_display_manager.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws/user_display_manager.h [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws/user_display_manager_unittest.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws/window_manager_state.h [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws/window_tree_unittest.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws2/BUILD.gn [delete] https://crrev.com/2822f05d1188407b17372cb3aa849075107ca6d8/services/ui/ws2/display_manager_mus.h [rename] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws2/screen_provider.cc [add] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws2/screen_provider.h [rename] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws2/screen_provider_unittest.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws2/window_service.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/services/ui/ws2/window_service.h [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/ui/views/mus/screen_mus.cc [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/ui/views/mus/screen_mus.h [modify] https://crrev.com/7d3e3473631c50f6bac67901fc98c34611905891/ui/views/mus/screen_mus_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/242f9d41c13bddbcb649026ec919151c0443cf60 commit 242f9d41c13bddbcb649026ec919151c0443cf60 Author: James Cook <jamescook@chromium.org> Date: Thu May 10 22:20:48 2018 Support FrameDecorationValues in ui::ws2::ScreenProvider More support for WindowService as a library. Expose a method to set the frame decoration metrics (e.g. client area insets). Bug: 839592 Test: added to services_unittests Change-Id: I44ead634ad2c5ceb35020efcf5a301aced6ec603 Reviewed-on: https://chromium-review.googlesource.com/1053557 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#557691} [modify] https://crrev.com/242f9d41c13bddbcb649026ec919151c0443cf60/ash/ws/window_service_util.cc [modify] https://crrev.com/242f9d41c13bddbcb649026ec919151c0443cf60/services/ui/ws2/screen_provider.cc [modify] https://crrev.com/242f9d41c13bddbcb649026ec919151c0443cf60/services/ui/ws2/screen_provider.h [modify] https://crrev.com/242f9d41c13bddbcb649026ec919151c0443cf60/services/ui/ws2/screen_provider_unittest.cc [modify] https://crrev.com/242f9d41c13bddbcb649026ec919151c0443cf60/services/ui/ws2/window_service.cc [modify] https://crrev.com/242f9d41c13bddbcb649026ec919151c0443cf60/services/ui/ws2/window_service.h
Comment 1 by sky@chromium.org
, May 7 2018Status: Assigned (was: Untriaged)