New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839583 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
r...@chromium.org
█ xiaoyinh@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

[Regression] Views-based login UI needs some polish when Gaia screen is shown

Project Member Reported by wzang@chromium.org, May 3 2018 
When Gaia screen is shown, the views-based login screen has the following differences with the WebUI login:

1) The user pods should be hidden.
2) The black background should be removed.
3) The default wallpaper should be shown (currently it's blocked by the black background), and when the Gaia screen is closed, it should change to the custom wallpaper of the focused user pod.

Comment 1 by wzang@chromium.org, May 3 2018

Components: -UI>SignIn UI>Shell>StartScreen
Screenshot from 2018-05-03 14-38-18.png
51.8 KB View Download
Screenshot from 2018-05-03 14-47-54.png
29.6 KB View Download

Comment 2 by wzang@chromium.org, May 3 2018 

and 4) The shelf icons should be hidden (e.g. "Add Person" and "Browse as Guest")

Comment 3 by r...@chromium.org, May 4 2018

Labels: -Pri-2 ReleaseBlock-Stable Pri-1
Owner: jdufault@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc

commit 7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Jun 25 18:40:21 2018

cros: Views-login prevent gaia from being dismissed.

Sometimes the dialog should not be dismissed, such as when there are no users.

Bug: 839583
Change-Id: Iee275fb636e5842ba2e99b799b8c04539ea1c3bd
Reviewed-on: https://chromium-review.googlesource.com/1093882
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570105}
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc/ui/login/display_manager.js

Comment 5 by jdufault@chromium.org, Jun 25 2018

Labels: -M-68 M-69
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e1c4a5d018312d5cd79adde50a2db716fe88b04

commit 9e1c4a5d018312d5cd79adde50a2db716fe88b04
Author: Peter Williamson <petewil@chromium.org>
Date: Tue Jun 26 00:28:43 2018

Revert "cros: Views-login prevent gaia from being dismissed."

This reverts commit 7e1ee3f6f677a8560d1e47fca3fe286f94ce5cbc.

Reason for revert:
Sheriff is reverting on suspicion of causing build failures in Linux-chromeos-dbg.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6482

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000030708cc base::debug::StackTrace::StackTrace()
#1 0x000002a06b85 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f1b84f32cb0 <unknown>
#3 0x000001b623b4 chromeos::OobeUIDialogDelegate::GetOobeUI()
#4 0x000001b5e99e chromeos::LoginDisplayMojo::LoginDisplayMojo()
#5 0x000001b58e56 chromeos::LoginDisplayHostMojo::LoginDisplayHostMojo()
#6 0x000001b5e397 (anonymous namespace)::ShowLoginWizardFinish()
#7 0x000001b5dcc3 chromeos::ShowLoginWizard()



Original change's description:
> cros: Views-login prevent gaia from being dismissed.
> 
> Sometimes the dialog should not be dismissed, such as when there are no users.
> 
> Bug: 839583
> Change-Id: Iee275fb636e5842ba2e99b799b8c04539ea1c3bd
> Reviewed-on: https://chromium-review.googlesource.com/1093882
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570105}

TBR=xiyuan@chromium.org,jdufault@chromium.org

Change-Id: I031f7ab7e627f1aedea76fb24f8ad4b2f97eb804
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839583
Reviewed-on: https://chromium-review.googlesource.com/1114048
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570265}
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/9e1c4a5d018312d5cd79adde50a2db716fe88b04/ui/login/display_manager.js
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55

commit 4f4fa35aedce1575798ae69caf3a3f05c4bf7c55
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Jun 27 17:31:07 2018

Reland cros: Views-login prevent gaia from being dismissed.

Fix bad rebase. This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1093882.

TBR=xiyuan@chromium.org

Bug: 839583
Change-Id: I70d994b15131404f479e3d0c1e585549fecbf6af
Reviewed-on: https://chromium-review.googlesource.com/1115724
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570826}
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/4f4fa35aedce1575798ae69caf3a3f05c4bf7c55/ui/login/display_manager.js

Comment 8 by jdufault@chromium.org, Aug 1

Labels: -M-69 M-70

Comment 9 by jdufault@chromium.org, Aug 9

Owner: wzang@chromium.org

Comment 10 by jdufault@chromium.org, Aug 9 

wzang: shelf buttons should be taken care of by xiaoyinh@ in a separate CL, but wallpaper/hiding background content is not currently being worked on

Comment 11 by wzang@chromium.org, Aug 10 

3) in the bug description is already fixed with  issue 836112 .

2) is tricky: the dark background is from the screen dimmer in [1]. It's the default behavior for all the modals that're in the |kShellWindowId_LockSystemModalContainer| container. We might consider making the dialog fill the entire screen to avoid showing the dark background instead.

1) is easily fixable by toggling the visibility of |lock_contents_view|. However it may not be worthwhile, because most of the time the user pods are blocked by the OOBE dialog anyway, and for 6+ users, the small user pods are blocked by the dark background so there's no legibility issue. I think it's better to avoid this since hiding the entire login view is not a trivial UI change.


[1] https://cs.chromium.org/chromium/src/ash/wm/system_modal_container_layout_manager.cc?rcl=6d46d04b39e5b181dcd57dd2329063010ab16ced&l=159

Comment 12 by jdufault@chromium.org, Aug 10 

For 2), I wonder how challenging it would be to move gaia dialog out of the modal container into a different/new container.

Comment 13 by jdufault@chromium.org, Aug 23

Labels: -ReleaseBlock-Stable

Comment 14 by zalcorn@chromium.org, Dec 12

Cc: wzang@chromium.org
Labels: -Pri-1 -M-70 Hotlist-auth-polish Pri-3
Owner: ----
Status: Available (was: Assigned)
►

Sign in to add a comment