New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839578 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
█ krajshree@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Omnibox] light half circle in suggestion row

Project Member Reported by dschuyler@chromium.org, May 3 2018 
1. enable omnibox-rich-entity-suggestions
2. do some entity searches (try names like "Chris")
3. do a non entity search
4. mouse over the results

Problem: some results may show a faint half circle (where the entity image was shown). The entity image is not being correctly reset.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7080df993159999758745dd939315d575bcc4ba4

commit 7080df993159999758745dd939315d575bcc4ba4
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri May 04 20:56:54 2018

[Omnibox] Don't show image on single line suggestions

This Cl resets the suggestion image so that the entity image is not seen
in a non-entity result.

Bug:  839578 
Change-Id: I398aee581b559dd8a59ad2d55581f5d55cbbfea5
Reviewed-on: https://chromium-review.googlesource.com/1043101
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556186}
[modify] https://crrev.com/7080df993159999758745dd939315d575bcc4ba4/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc

Comment 2 by dschuyler@chromium.org, May 4 2018

Status: Fixed (was: Started)

Comment 3 by krajshree@chromium.org, May 7 2018

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tried testing the issue on mac 10.13.3 using build with fix and without fix by following the steps from comment #0.
Did not observe any faint half circle for any of the search results when tested using build without fix (chrome version #68.0.3419.0).
Same behaviour was also observed when tested using build with the fix (chrome version #68.0.3423.0).

Attaching screen casts for reference.

dschuyler@ - Could you please check the attached screen casts and please help us in confirming the fix.

Thanks...!!
839578@withfix.mp4
854 KB View Download
839578@withoutfix.mp4
947 KB View Download

Comment 4 by dschuyler@chromium.org, May 7 2018 

on step (4) it may be easier to cursor down.

I've attached a screen shot to illustrate the issue.
Screenshot from 2018-05-07 11-31-07.png
95.4 KB View Download

Comment 5 by krajshree@chromium.org, May 8 2018 

Tried testing the issue on mac 10.13.3 using build with fix and without fix by following the steps from comment #0 and #4.
Did not observe any faint half circle for any of the search results on step (4) after doing cursor down and hovering over the search results when tested using build without fix (chrome version #68.0.3419.0).
Same behaviour was also observed when tested using build with the fix (chrome version #68.0.3423.2).

Attaching screen casts for reference.

dschuyler@ - Could you please check the attached screen casts and please help us in verifying the fix.

Thanks...!!
839578@68.0.3419.0.mp4
994 KB View Download
839578@68.0.3423.2.mp4
516 KB View Download
►

Sign in to add a comment