New issue
Advanced search Search tips

Issue 839572 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----



Sign in to add a comment

ModuleEventSinkImplTest.CallsForwardedAsExpected Failing on Windows

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 3 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jonross@google.com

ModuleEventSinkImplTest.CallsForwardedAsExpected has begun failing on Windows on multiple builders. Nothing in the blamelists for the first failures on each builder strikes me as the source.

chrisha@ & pmonette@ could you help triage this issue?

Stack Trace:
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	content::BrowserThread::PostTask [0x016A9C5E+178]
	content::BrowserThread::PostTask [0x016A9BED+65]
	AfterStartupTaskUtils::IsBrowserStartupComplete [0x02AAF72C+252]
	AfterStartupTaskUtils::PostTask [0x02AAF48B+187]
	ModuleInspector::StartInspectingModule [0x02AF20EF+309]
	ModuleInspector::AddModule [0x02AF1FB4+48]
	ModuleDatabase::FindOrCreateModuleInfo [0x02AF049C+126]
	ModuleDatabase::OnModuleLoad [0x02AF05FA+58]
	ModuleEventSinkImpl::OnModuleEvent [0x02AF1313+419]
	ModuleEventSinkImplTest_CallsForwardedAsExpected_Test::TestBody [0x001E7B66+518]
	testing::Test::Run [0x00F4A176+192]
	testing::TestInfo::Run [0x00F4A928+210]
	testing::TestCase::Run [0x00F4AD5A+244]
	testing::internal::UnitTestImpl::RunAllTests [0x00F50E35+629]
	testing::UnitTest::Run [0x00F50ABB+153]
	base::TestSuite::Run [0x023A6448+100]
	base::LaunchUnitTests [0x023A71C0+452]
	base::LaunchUnitTests [0x023A708B+143]
	main [0x04CB83C6+234]
	__scrt_common_main_seh [0x0558AB8A+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	BaseThreadInitThunk [0x7640336A+18]
	RtlInitializeExceptionChain [0x76F59902+99]
	RtlInitializeExceptionChain [0x76F598D5+54]

Builders failed on: 
- Win 7 Tests x64 (1): 
  https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29
- Win10 Tests x64: 
  https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64
- Win7 Tests (1): 
  https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f28e1c437fc0236bba7fd3336e57cac1bdc01748

commit f28e1c437fc0236bba7fd3336e57cac1bdc01748
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu May 03 22:32:16 2018

Fix failing test in ModuleEventSinkImpl

Tbr: chrisha@chromium.org
Bug:  839572 
Change-Id: Iaf2a127be786efa2ce195f5b952aaecd0f1a9e74
Reviewed-on: https://chromium-review.googlesource.com/1043155
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555891}
[modify] https://crrev.com/f28e1c437fc0236bba7fd3336e57cac1bdc01748/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc

Comment 2 by treib@chromium.org, May 4 2018

Components: Tests>Flaky
Labels: OS-Windows
Owner: pmonette@chromium.org
Status: Fixed (was: Available)
Seems to be fixed: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ModuleEventSinkImplTest.CallsForwardedAsExpected
Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa3f7cc87ba395cf3626497465df539dea06fd83

commit fa3f7cc87ba395cf3626497465df539dea06fd83
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri May 18 04:58:03 2018

Fix failing test in ModuleEventSinkImpl

Tbr: chrisha@chromium.org
Bug:  839572 
Change-Id: Iaf2a127be786efa2ce195f5b952aaecd0f1a9e74
Reviewed-on: https://chromium-review.googlesource.com/1043155
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555891}(cherry picked from commit f28e1c437fc0236bba7fd3336e57cac1bdc01748)
Reviewed-on: https://chromium-review.googlesource.com/1065570
Cr-Commit-Position: refs/branch-heads/3396@{#635}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/fa3f7cc87ba395cf3626497465df539dea06fd83/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc

Sign in to add a comment