Issue metadata
Sign in to add a comment
|
52.3%-68.3% regression in blink_perf.bindings at 555060:555140 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 3 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1491ada3c40000
,
May 4 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/1491ada3c40000 'ReadHistogramsJsonValue' object has no attribute '_results_filename'
,
May 7 2018
Can someone trigger a new Pinpoint run? This regression looks pretty big, and I couldn't think of any specific changes in the reported range that could've caused it.
,
May 7 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/129e9607c40000
,
May 9 2018
📍 Found significant differences after each of 9 commits. https://pinpoint-dot-chromeperf.appspot.com/job/129e9607c40000 Add ARCoreDevice rendering path by lincolnfrog@chromium.org https://chromium.googlesource.com/chromium/src/+/5419fb537bcc85f88b99f71d244518a96c483498 Bypass tail time computation if IIR filter is unstable by rtoy@chromium.org https://chromium.googlesource.com/chromium/src/+/949538bb77dce13f23abe328338f50f39c6350e0 Allow URLLoaderInterceptor to support intercepting frame requests when network service is disabled. by jam@chromium.org https://chromium.googlesource.com/chromium/src/+/db3a13b32f24a916ff5dc1effd6180bfe2df8df7 Eliminate unnecessary lifecycle work on a document being swapped out by szager@chromium.org https://chromium.googlesource.com/chromium/src/+/b6351b8605d9560a2df9ed18fcd1467c34fe56ed [V8 Platform] Introduce CallDelayedOnWorkerThread() by gab@chromium.org https://chromium.googlesource.com/v8/v8/+/4b13a22ff477d56ead2ee452ac4bba52d8f05e92 [V8 Platform] Better WorkerThreads APIs. by gab@chromium.org https://chromium.googlesource.com/v8/v8/+/4ac96190f74f94f6950c3c8c817ae444efc22b6b Update V8 to version 6.8.117. by v8-autoroll@chromium.org https://chromium.googlesource.com/chromium/src/+/f26adef3a8228aab2f69d7a941138508d80d139e [DevTools] improve safety of Runtime.terminateExecution by kozyatinskiy@chromium.org https://chromium.googlesource.com/chromium/src/+/8d0f1f7aa1dd3f8cc4eb3bfe2c6a2deeb30fa2b1 [media] Use pixel aspect ratio to compute |natural_size| in all decoders. by sandersd@chromium.org https://chromium.googlesource.com/chromium/src/+/af451f2b8adfb22eabf60b7232a3c050941c9261 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 9 2018
Doesn't look like media. Perhaps V8?
,
May 9 2018
Most likely it is mine "[DevTools] improve safety of Runtime.terminateExecution"
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/aab49f372f48354a32248de858a8347275517062 commit aab49f372f48354a32248de858a8347275517062 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed May 09 22:31:39 2018 [inspector] do not allocate scope inside CallStackDepth Allocation is super slow and produce big performance regression on blink side. Bug: chromium:839567 ,chromium:839809 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3e9989435515ecfaedaee60c1f0c6939b9053e95 Reviewed-on: https://chromium-review.googlesource.com/1053105 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53115} [modify] https://crrev.com/aab49f372f48354a32248de858a8347275517062/src/api.cc [modify] https://crrev.com/aab49f372f48354a32248de858a8347275517062/src/execution.cc [modify] https://crrev.com/aab49f372f48354a32248de858a8347275517062/src/isolate.h
,
Sep 25
It becomes better with my CL and since other metrics are not affected by my CL and it is required for Runtime.terminateExecution method that is widely used now, I mark it as fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 3 2018