Animation Worklet - Do not tick Worklet Animation on main thread |
||
Issue descriptionWe should not tick cc:WorkletAnimation on main thread. The value produces on main thread has not value and it causes superfluous commits. Issue 762717 tracks doing the same for all animation but WorkletAnimation case is much simpler and we can do that now.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3698e89bf23d74b96c09610d6425a601f567f714 commit 3698e89bf23d74b96c09610d6425a601f567f714 Author: Majid Valipour <majidvp@chromium.org> Date: Fri May 04 23:44:51 2018 [animation-worklet] Do not tick worklet animations on main thread We should not tick cc:WorkletAnimation on main thread. The local time is actually not updated on main thread so the produced value is incorrect and more importantly causes superfluous commits. Note: We may decide to avoid ticking all animations on main thread (See http://crbug.com/762717) in which case we can remove this. TEST: cc/animation/worklet_animation_unittest.cc Bug: 839555 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3335bfd452cc284a585e84a87b8912207b843813 Reviewed-on: https://chromium-review.googlesource.com/1042875 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556256} [modify] https://crrev.com/3698e89bf23d74b96c09610d6425a601f567f714/cc/animation/worklet_animation.cc [modify] https://crrev.com/3698e89bf23d74b96c09610d6425a601f567f714/cc/animation/worklet_animation.h [modify] https://crrev.com/3698e89bf23d74b96c09610d6425a601f567f714/cc/animation/worklet_animation_unittest.cc
,
May 15 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by majidvp@chromium.org
, May 3 2018Status: Started (was: Assigned)