Issue metadata
Sign in to add a comment
|
[CocoaBrowser] Tab Close Button (X) is not white for hovered and pressed states |
||||||||||||||||||||||
Issue descriptionChrome Version: Canary 68.0.3418.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Run Chrome in normal Cocoa Mode (2) Hover and/or press on the Tab Close Button What is the expected result? White (X). What happens instead? Dark (X). This was fixed for MacViews in issue 838523 . But I noticed that the issue is also present in Cocoa-Mode. It would be nice to see it fixed there, too. Thanks :-) Mehmet
,
May 3 2018
Great! Thanks a lot :)
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee7b0b18d63d371c02a7f741dbffd87abeacf872 commit ee7b0b18d63d371c02a7f741dbffd87abeacf872 Author: Allen Bauer <kylixrd@chromium.org> Date: Thu May 03 21:40:40 2018 Make sure the close (X) on the Cocoa tab is white when highlighted. Bug: 839534 Change-Id: I7242753e5777b15168ba8a0ff91a000a8a16c980 Reviewed-on: https://chromium-review.googlesource.com/1042624 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#555885} [modify] https://crrev.com/ee7b0b18d63d371c02a7f741dbffd87abeacf872/chrome/browser/ui/cocoa/hover_close_button.mm
,
May 3 2018
[mac bug triage] Assigning to kylixrd@. Please close the bug if this is resolved
,
May 4 2018
Able to reproduce this issue on Mac OS 10.12.6 on the reported version 68.0.3418.0 and the issue is fixed on the latest Canary 68.0.3419.0 as per the original comment. On hovering the mouse pointer on tab close button, can observe that the icon is displayed in white color. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
May 4 2018
kylixrd@: Thanks for the fix. Everything works fine again in latest Canary. White (X) on the close button of the Normal & Incognito tabs in Cocoa-Mode again :)
,
May 4 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kylixrd@chromium.org
, May 3 2018