[Fullscreen Control] Integrate FullscreenControlHost with Mac |
|||
Issue descriptionWe don't need the fullscreen exit UI on Mac for mouse and touch scenarios, but we do need it for system keyboard lock. This bug tracks works to get FullscreenControlHost integrated with Mac.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d0fab63c914bdb0536ef0b7b4d7b16e9ecb2c63 commit 9d0fab63c914bdb0536ef0b7b4d7b16e9ecb2c63 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed May 09 23:23:14 2018 [Fullscreen Control] Integrate with MacViews This CL integrates the FullscreenControlHost with the MacViews toolkit so that keyboard lock can use it as the visual feedback for press-and-hold ESC to exit fullscreen. Bug: 839530 Change-Id: I0d8792114840b039ce72ec4a755bdf1fc887d723 Reviewed-on: https://chromium-review.googlesource.com/1050930 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#557373} [modify] https://crrev.com/9d0fab63c914bdb0536ef0b7b4d7b16e9ecb2c63/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/9d0fab63c914bdb0536ef0b7b4d7b16e9ecb2c63/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/9d0fab63c914bdb0536ef0b7b4d7b16e9ecb2c63/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
,
May 25 2018
,
May 28 2018
@Yuwei Huang: As we are not very clear about the expected behaviour after the fix and the earlier behaviour, It would be highly helpful if elaborated on it. Any other inputs from your end may be very helpful in verifying the fix. Thanks!
,
Oct 5
Basically before the integration is done, the drop down "X" animation will not show up on Mac when: 1. The web page requests keyboard lock on the ESC key 2. The user enters fullscreen 3. The user presses and holds the ESC key This is working now after the fix. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 7 2018