ToT r555721, run chrome with "--enable-features=Mash" on device. Browser windows, launcher etc does not get any mouse events. Only shelf and system
This seems related to
https://chromium-review.googlesource.com/c/chromium/src/+/1025633
Revert the CL fixes the issue.
sky@ suggested that we could restore the old behavior for mash for now.
Do we know why that change is causing an issue for mash? I landed it to fix some x11 testing issues but it seems like it actually fixed some other Crostini caption issues too so it would be nice if it didn't need to be reverted
Cc: penghuang@chromium.org Summary: mash/mus: No mouse events on workarea on device (was: mash: No mouse events on workarea on device)
+penghuang
This is broken for mus too, like what we had before in issue 757542 .
Not sure why it works without mus/mash. Having TARGET_AND_DESCENDANTS on ExoShellSurface should gets the event dispatched to ExoShellSurface.
Found this doc (might be out of date) for event dispatching on mus:
https://docs.google.com/document/d/1zdtEQ9K4H6lVDDIMEmEDtHUwLfA-xKCuNqZVL-4UK7I/edit?usp=sharing
Snippet from the doc:
====
Mouse-press (or touch-press) events go to the window under the cursor (or touch-point). This sets an implicit capture (and so subsequent mouse-move and mouse-release events are also dispatched to that window).
Mouse-move events go to the window under the cursor if no mouse-button is active.
====
In our case here, when mus/mash is enabled, ExoShellSurface in SystemModalContainer will gets the mouse events. Even though it correctly says it does not handle the event, the event is not dispatched to windows under it.
The event dispatching code is changing. As a temp workaround, let's use the old behavior on mus/mash. We can revisit this afterwards.
Comment 1 by reve...@chromium.org
, May 3 2018