New issue
Advanced search Search tips

Issue 839513 link

Starred by 1 user
Status: Duplicate
Merged: issue 839514
Owner:
mlippautz@chromium.org
Closed: May 2018
Cc:
cjgrant@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

103 KB (0.1%) regression in resource_sizes (MonochromePublic.apk) at 555449:555449

Project Member Reported by cjgrant@google.com, May 3 2018 
Caused by: [oilpan] Enable incremental marking buildflag

(but then reverted)

Original commit: d8a31d453aaa429829d6ba183f94b5ba016768bd
Revert commit: b1940e0ce70651ca8cb36787ed0a96ace34eace3 

It's not clear whether or not this increase was expected, but, the revert cites suspected breakage of unit tests (not binary size impact).  The size impact is also substantial.

Before re-landing, could you indicate on this bug whether such an increase is expected or not?
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 3 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=839513

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=14610f76f3197697dd7f17570b6760bb62f967d8211d69d64e12358779657d72


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 3 2018 

Assigning to mlippautz@chromium.org because this is the only CL in range:
[oilpan] Enable incremental marking buildflag

Includes incremental garbage collection infrastructure in regular
builds. Does not enable incremental marking at runtime!

This CL may cause throughput regressions and is an attempt
to collect a broad range of potential performance issues.

Bug:  chromium:757440 
Change-Id: Ie7b75f8d96f9230400beed1a3258e45e0ca742ed
Reviewed-on: https://chromium-review.googlesource.com/980753
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555449}

Comment 3 by cjgrant@chromium.org, May 3 2018

Mergedinto: 839514
Status: Duplicate (was: Assigned)
Whoops, I'm not sure how I managed to make the tool generate a duplicate.
►

Sign in to add a comment