Decouple minifier from GRIT |
|||
Issue descriptionFrom discussion on: https://chromium-review.googlesource.com/c/chromium/src/+/1031108 Currently script minifier is invoked/controlled from GRD/GRIT tools but this is not a good design. The CL above adds a skip_minifier flag to bundle module scripts that can't be processed by the current minifier, but in the long-term minifier-related mechanisms in GRIT (js_minify, skip_minifier) should be removed from GRIT and instead minifier should be applied before GRIT.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92165b0af7b2a8287a71eee5deef3fc3c2894feb commit 92165b0af7b2a8287a71eee5deef3fc3c2894feb Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri May 04 00:59:53 2018 Add skip_minify option to grit tool As the current minifier doesn't support module scripts (e.g. import statements) and [1] is going to add module scripts that contain imports to a grit archive, this CL adds a |skip_minify| option to skip minifier for individual files as a workaround. |skip_minify| will be used in [1]. [1] https://chromium-review.googlesource.com/1031749 Bug: 829084, 839512 Change-Id: Ie4c3ad21cd2ef8cfb715d0eb57e7045f754acc1a Reviewed-on: https://chromium-review.googlesource.com/1031108 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555940} [modify] https://crrev.com/92165b0af7b2a8287a71eee5deef3fc3c2894feb/tools/grit/grit/node/include.py
,
May 4 2018
This seems to be owned in practice by hiroshige, so I'll assign it to him.
,
Jan 18
(5 days ago)
,
Jan 18
(5 days ago)
@hiroshige: FYI I am trying to figure out how to satisfy the Closure compiler while using modules in WebUI, as part of issue 915053, which might be related to what you are trying to do as well.
,
Jan 18
(5 days ago)
Thanks, that information is quite helpful! |
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, May 3 2018Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows