New issue
Advanced search Search tips

Issue 839496 link

Starred by 1 user
Status: Fixed
Owner:
kmarshall@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

fuchsia packages are not rebuilt in component built when necessary

Project Member Reported by sergeyu@chromium.org, May 3 2018 
1. Build webrunner package (webrunner_runner target) with is_component_build=true
2. Change a file in //base
3. Build webrunner_runner again
4. Observe that webrunner_runner package wasn't rebuilt, only libbase.so

Comment 1 by w...@chromium.org, May 3 2018 

This seems like the sort of thing that will lead to painful Debug FYI bot flakes from time to time - can we prioritizing addressing this, plz?

Comment 2 by kmarshall@chromium.org, May 3 2018 

I can repro it. Investigating.
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1322db809bcf2ab2305f64f4207fb3a239bd09ef

commit 1322db809bcf2ab2305f64f4207fb3a239bd09ef
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu May 03 21:52:42 2018

Fuchsia: Generate depfiles for incremental building of package contents.

Generating a depfile from the manifest building step gives Ninja
the information it needs to trigger incremental rebuilds when static
assets or shared libraries have been modified.

Bug:  839496 
Change-Id: I15aee25e8684f9d1fd6a8ad63318cc74639237f0
Reviewed-on: https://chromium-review.googlesource.com/1043047
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555887}
[modify] https://crrev.com/1322db809bcf2ab2305f64f4207fb3a239bd09ef/build/config/fuchsia/build_manifest.py
[modify] https://crrev.com/1322db809bcf2ab2305f64f4207fb3a239bd09ef/build/config/fuchsia/package.gni

Comment 4 by kmarshall@chromium.org, May 4 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment