New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839488 link

Starred by 2 users
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
█ vollick@chromium.org
tiborg@chromium.org
cjgrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Implement a scrollable linear layout container for the overflow menu

Project Member Reported by cjgrant@chromium.org, May 3 2018 
We need a scrollable container for the overflow menu, and possibly future UI.

Aldo is taking this on, and initial implementation discussions have happened.  Filing this bug for tracking.  The initial chat covered (loosely):

- The requirement to clip elements at the GL level (either via shader or other GL mechanism)
- The layout requirement of computing a clip rect while processing scene layout
- Scrolling and snap points
- The need for a clear and detailed UX spec on the menu's behavior
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c82205130fbb0a8b7a02bcded7d6675e86724728

commit c82205130fbb0a8b7a02bcded7d6675e86724728
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Fri May 04 21:15:22 2018

Modifying layout of buttons in overflow menu in preparation for
scrolling.

This change will allow to only scroll the portion defined by the UX
specs.

Extra nit: use a simpler conditional in a shader.

Bug:  839488 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ib5603d2b20786ccd07eb9bba0d31056f0ee1c54e
Reviewed-on: https://chromium-review.googlesource.com/1044115
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556195}
[modify] https://crrev.com/c82205130fbb0a8b7a02bcded7d6675e86724728/chrome/browser/vr/renderers/transparent_quad_renderer.cc
[modify] https://crrev.com/c82205130fbb0a8b7a02bcded7d6675e86724728/chrome/browser/vr/ui_scene_creator.cc
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee5a9c787f3222d1e6f75a50313cc059691feb02

commit ee5a9c787f3222d1e6f75a50313cc059691feb02
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Fri May 11 21:22:51 2018

VR: Ability to clip elements

It affects drawing and hit testing. If the quad is completely outside the clip, nothing is sent to the CPU.
This is going to be used to implement scrolling.
Also, this CL removes the unused copy_rect.

Bug:  839488 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I07c087f3d7860456587de092797349851c26502a
Reviewed-on: https://chromium-review.googlesource.com/1054371
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558021}
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/elements/content_element.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/elements/full_screen_rect.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/elements/rect.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/elements/ui_element_unittest.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/renderers/base_renderer.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/renderers/base_renderer.h
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/renderers/gradient_quad_renderer.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/renderers/gradient_quad_renderer.h
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/renderers/textured_quad_renderer.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/renderers/textured_quad_renderer.h
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/vr_gl_util.cc
[modify] https://crrev.com/ee5a9c787f3222d1e6f75a50313cc059691feb02/chrome/browser/vr/vr_gl_util.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/592b307fe84a33f94a90a8fa7f255fad3846a461

commit 592b307fe84a33f94a90a8fa7f255fad3846a461
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed May 16 13:23:51 2018

VR: Adding a scrollable element.

This UI element is used to build the scrollable overflow menu.

Bug:  839488 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I930b2b13f61e1533d74df6c5a4aab60089987450
Reviewed-on: https://chromium-review.googlesource.com/1055987
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559060}
[modify] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/elements/scrollable_element.cc
[add] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/elements/scrollable_element.h
[add] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/elements/scrollable_element_unittest.cc
[modify] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/592b307fe84a33f94a90a8fa7f255fad3846a461/chrome/browser/vr/ui_scene_creator.cc

Comment 4 by acondor@chromium.org, May 16 2018

Blockedon: 843239

Comment 5 by acondor@chromium.org, May 22 2018

Blockedon: -843239

Comment 6 by acondor@chromium.org, May 22 2018

Status: Fixed (was: Started)
►

Sign in to add a comment