New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839485 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Scheduler: frame scheduler isn't populated upon task queue instantiation.

Project Member Reported by farahcharab@chromium.org, May 3 2018

Issue description

Frame scheduler (member variable of QueueCreationParams in https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/scheduler/renderer/main_thread_task_queue.h) isn't getting populated when a task queue is associated to a frame scheduler.
 
Labels: Pri-2 Type-Task
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/390074a55de0aaf577335c97682b2e8ff00e6e40

commit 390074a55de0aaf577335c97682b2e8ff00e6e40
Author: Farah Charab <farahcharab@google.com>
Date: Wed May 09 08:13:47 2018

Scheduler: Populate queue creation parameter `frame_scheduler`.

Upon task queue instantiation, populate frame_scheduler when
task queue is associated to a frame.

Bug:  839485 
Change-Id: Iea60faf8dd5f015240a866e7189f252216982ce8
Reviewed-on: https://chromium-review.googlesource.com/1042577
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557121}
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
[modify] https://crrev.com/390074a55de0aaf577335c97682b2e8ff00e6e40/third_party/blink/renderer/platform/timer_test.cc

Sign in to add a comment