New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839478 link

Starred by 2 users
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Jul 23
Cc:
█ aposner@chromium.org
tbansal@chromium.org
bengr@chromium.org
█ bshealy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 840454



Sign in to add a comment

Data Saver home screen - drop confusing proxy unreachable error message

Project Member Reported by dougarnett@chromium.org, May 3 2018 
When the Data Saver home screen is presented and the data reduction proxy is currently unreachable, an error message is presented at the bottom of the screen view. Based on user feedback reports, this message is generally confusing to users. It is also not actionable. From discussion among PM/UX/ENG, we recommend simply dropping the display of this error message. Instead, we should perhaps log a warning message for this condition instead (so that it can be available in user feedback reports via the log).

Comment 1 by dougarnett@chromium.org, May 3 2018 

Here is screenshot of existing error message presentation (it is the "Chrome is unable to reach Google servers ..." string with warning triangle).
datasavererror.jpeg
19.4 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d23d886b84b818ce0d7e785beca9bf44128a9e03

commit d23d886b84b818ce0d7e785beca9bf44128a9e03
Author: Doug Arnett <dougarnett@chromium.org>
Date: Mon May 07 16:49:00 2018

Drops proxy unreachable error message from DataSaver home screen

Adds log message instead so situation will be available for user
feedback report based on this screen.

Tested log message locally by hacking threshold constants to simulate
blocked proxy condition.

Bug:  839478 
Change-Id: I92935bb164255187127096ac86820bb32b689b2e
Reviewed-on: https://chromium-review.googlesource.com/1042794
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556467}
[modify] https://crrev.com/d23d886b84b818ce0d7e785beca9bf44128a9e03/chrome/android/java/res/layout/data_reduction_stats_layout.xml
[modify] https://crrev.com/d23d886b84b818ce0d7e785beca9bf44128a9e03/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
[modify] https://crrev.com/d23d886b84b818ce0d7e785beca9bf44128a9e03/chrome/android/java/strings/android_chrome_strings.grd

Comment 3 by aposner@chromium.org, May 7 2018

Blocking: 840454

Comment 4 by bengr@chromium.org, May 21 2018

Status: Started (was: Assigned)
Is this fixed?

Comment 5 by ryansturm@chromium.org, Jul 6 

dougarnett, can this be closed?

Comment 6 by dougarnett@chromium.org, Jul 23

Status: Fixed (was: Started)
►

Sign in to add a comment