New issue
Advanced search Search tips

Issue 839473 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: May 2018
Cc:
pauljensen@chromium.org
ericorth@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 837333



Sign in to add a comment

Migrate consumers of NetworkChangeNotifier::DNSObserver to DNSConfigService

Project Member Reported by xunji...@chromium.org, May 3 2018 
non-//net consumers of NetworkChangeNotifier::DNSObserver should really use DNSConfigService's ReadConfig()/WatchConfig() to get notified about DNS config changes.

Consumers that need to be converted:
- chrome/browser/net/dns_probe_service.cc
- components/certificate_transparency/log_dns_client.cc
- jingle/notifier/communicator/login.cc

This is so we can have one and not two DNS config notification interface in network service.

Comment 1 by xunji...@chromium.org, May 3 2018

Status: WontFix (was: Untriaged)
I chatted with Paul offline.

DNSObserver is the interface that //net exposes. DNSConfigService is a private net class. 

NetworkChangeNotifier sets up DNSConfigService on a different thread and handles posting those callbacks to DNSObservers' threads.

With network service, the threading issue is less applicable. As long as we have a relatively simple interface to watch DNS config changes, mojo will take care of posting callbacks to the right threads.

I will close this as WontFix for now. Eric will be looking into servicify DNS interfaces, and we can revisit as needed.
►

Sign in to add a comment