Move ExtensionKeybindingRegistryViews Instantiation out of Widget Activation |
|||
Issue descriptionIf the widget is never activated and an extension is loaded, extension command keybindings are not registered. This broke interactive_ui_tests CommandsApiTest.Basic on Mac where the window currently does not receive activation during the test. Introduced by https://chromium.googlesource.com/chromium/src/+/6a216395c4e3acd97f8143853d47ef3f9fb51d2f
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f19e58e7e6e58c17bb5e115a53ae7d02e949c79f commit f19e58e7e6e58c17bb5e115a53ae7d02e949c79f Author: Robert Liao <robliao@chromium.org> Date: Mon May 07 20:08:25 2018 Activate the Browser Window on Mac for interactive_ui_tests CommandsApiTest.Basic ExtensionKeybindingRegistryViews doesn't get registered until BrowserView receives activation at least once. On Mac, due to crbug.com/650859, widgets may not receive activation during tests. The impact here is that extension command keybindings never register and CommandsApiTest.Basic waits until timeout for the keybinding to trigger the command. The workaround activates the window for the test. BUG=834754,650859,839469 Change-Id: I0488e515cbcb5bd1941611b2c10d72cc9b69e7bd Reviewed-on: https://chromium-review.googlesource.com/1042787 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556543} [modify] https://crrev.com/f19e58e7e6e58c17bb5e115a53ae7d02e949c79f/chrome/browser/extensions/extension_keybinding_apitest.cc
,
Nov 20
*** UI Mass Triage *** Assuming this is fixed. If you think that this bug still needs to be addressed, please reopen or file a new issue. Thanks!
,
Nov 20
This is not fixed yet. |
|||
►
Sign in to add a comment |
|||
Comment 1 by robliao@chromium.org
, May 3 2018