New issue
Advanced search Search tips

Issue 839467 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 781021

Blocking:
issue 842132
issue 871453



Sign in to add a comment

Swarming: find a way to describe nicely task fallback in the CLI tool

Project Member Reported by mar...@chromium.org, May 3 2018

Issue description

Right now the only way to do a TaskRequest with multiple TaskSlice is to use the low level "swarming.py post" subcommand.

AI:
- Figure out the uses cases for task requests with multiple task slice.
- Define flags to state that some dimensions are 'optional' and with an intermediary expiration delay, to create simple 'warm/cold' task type.

 
Blocking: 842132
Status: Fixed (was: Available)
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/6ddde54621fa69282036b1fbca6dc33d73bc6296

commit 6ddde54621fa69282036b1fbca6dc33d73bc6296
Author: Brad Hall <bradhall@google.com>
Date: Fri Oct 19 17:08:55 2018

Add optional-dimension argument to swarming

This adds an optional argument to swarming.py (--optional-dimension)
which takes the form "key value expiration".  If any optional dimension
entries are specified we will create additional task slices for them
using (key, value) as the dimension and expiration as the task
expiration value.


Bug: 871453
Change-Id: I17607786809d725341596b9c531dc1f6ee9ee689
Reviewed-on: https://chromium-review.googlesource.com/c/1269156
Commit-Queue: Brad Hall <bradhall@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/6ddde54621fa69282036b1fbca6dc33d73bc6296/client/swarming.py
[modify] https://crrev.com/6ddde54621fa69282036b1fbca6dc33d73bc6296/client/tests/swarming_test.py


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f884208b23aab5ace10c5a119889507bd7e32aa

commit 0f884208b23aab5ace10c5a119889507bd7e32aa
Author: Brad Hall <bradhall@google.com>
Date: Fri Oct 19 18:34:00 2018

Roll src/tools/swarming_client/ 486c9b53c..f78187ab7 (16 commits)

https://chromium.googlesource.com/infra/luci/client-py.git/+log/486c9b53c4d5..f78187ab7712

$ git log 486c9b53c..f78187ab7 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 bradhall Add optional-dimension argument to swarming
2018-10-08 robertocn [run_isolated] Replace parameters in environment variables.
2018-09-28 borenet Fix symlink bug in file_path.set_read_only()
2018-09-24 maruel [client] improve NamedCache logging
2018-09-24 maruel [client] fix unit test on macOS
2018-09-10 maruel [client] Enforce missing named cache hints
2018-09-04 brucedawson Print precise instructions on collecting swarming results
2018-09-04 maruel [client] fix condition for object
2018-08-31 brucedawson Update README.md with contribution instructions
2018-08-31 brucedawson Print details when kill(9) fails
2018-08-29 maruel [client] Implement the bot side of named cache size hint
2018-08-10 maruel [client] round time in LRU at the second
2018-08-08 maruel [client] uninstall in reverse order
2018-08-03 maruel [client] stop trimming cache in run_isolated
2018-08-01 maruel client: Add Cache.save()
2018-07-25 maruel [client] Overhaul temporary directory override in run_isolated

Created with:
  roll-dep src/tools/swarming_client

Bug: 871453
Change-Id: I6ab8a24b99a1424e4ed30835cb75ac14b116507f
Reviewed-on: https://chromium-review.googlesource.com/c/1291779
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Brad Hall <bradhall@google.com>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601233}
[modify] https://crrev.com/0f884208b23aab5ace10c5a119889507bd7e32aa/DEPS
Blocking: 871453

Sign in to add a comment