New issue
Advanced search Search tips

Issue 839464 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 781021



Sign in to add a comment

Swarming: correctly render TaskRequest with multiple TaskSlice

Project Member Reported by mar...@chromium.org, May 3 2018

Issue description

There's now a feature where a task can have multiple TaskSlice, each containing a TaskProperties. The Web UI needs to be tweaked to surface this, in addition to task result's current_task_slice.
 

Comment 1 by maruel@google.com, Jun 3 2018

Labels: -Pri-3 Pri-1

Comment 2 by maruel@google.com, Jun 3 2018

Bumping priority as this will become problematic as people start using the feature and the UI is lying.
Status: Started (was: Assigned)
I can look at this today.  Any example tasks that I can look at?
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/2e6d24a07e86188b9b853442a0c3961fdd342e4d

commit 2e6d24a07e86188b9b853442a0c3961fdd342e4d
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jun 04 19:07:39 2018

Make Swarming UI handle multiple TaskSlices

It adds tabs for when there are multiple, defaulting
to show the tab of the slice that was run, which
is listed in result.current_task_slice

Bug:  839464 
Change-Id: I97a3cd0563e56978fc8cdeef4e064bcb40c12520
Reviewed-on: https://chromium-review.googlesource.com/1085272
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/2e6d24a07e86188b9b853442a0c3961fdd342e4d/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/2e6d24a07e86188b9b853442a0c3961fdd342e4d/appengine/swarming/ui/res/imp/taskpage/task-page-demo.html
[modify] https://crrev.com/2e6d24a07e86188b9b853442a0c3961fdd342e4d/appengine/swarming/ui/res/imp/taskpage/task-page.html

Comment 5 by kjlubick@google.com, Jun 11 2018

Status: Fixed (was: Started)
I believe this is live to chromium-swarm

Sign in to add a comment