New issue
Advanced search Search tips

Issue 839462 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 819212
issue 839454



Sign in to add a comment

Bookmarks: Implement new styling for BookmarkEditViewController

Project Member Reported by rohitrao@chromium.org, May 3 2018

Issue description

Implement the new styling for cells in the edit bookmarks screen.  This will involve implementing new cells under UIRefresh, but we should be able to reuse the same items.
 
Blocking: 819212
NextAction: 2018-05-23

Comment 3 by sczs@chromium.org, May 15 2018

Cc: -sczs@chromium.org rohitrao@chromium.org
Owner: sczs@chromium.org
I'll start working on this right after  crbug.com/843155 
Project Member

Comment 4 by sheriffbot@chromium.org, May 18 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by sczs@chromium.org, May 18 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc0fa84ee827770025f40b1a1c00704aa24e89fb

commit bc0fa84ee827770025f40b1a1c00704aa24e89fb
Author: sczs <sczs@chromium.org>
Date: Mon May 21 23:57:15 2018

[ios] Changes BookmarkEditVC style to UIRefresh.

- Styles bookmark_edit_view_controller to UIRefresh.
- Expands bookmark_text_field_item functionality to support URL checking.

Since we don't have the final mocks/colors for the error label, I'll fix that on a small followup CL.

Screnshoots:
https://drive.google.com/open?id=1Om2oGs97vF5I1RAV2p-nPt7lUjN1L-0I
https://drive.google.com/open?id=1TIxoFEtyYtTp1KNEaszfPjEh9t7zziTl


Bug:  839462 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I32bec3aaf6c464bbf8d8e959a3108735db87ed40
Reviewed-on: https://chromium-review.googlesource.com/1066790
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560415}
[modify] https://crrev.com/bc0fa84ee827770025f40b1a1c00704aa24e89fb/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[modify] https://crrev.com/bc0fa84ee827770025f40b1a1c00704aa24e89fb/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.h
[modify] https://crrev.com/bc0fa84ee827770025f40b1a1c00704aa24e89fb/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.mm

Comment 7 by sczs@chromium.org, May 23 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-05-23

Sign in to add a comment