New issue
Advanced search Search tips

Issue 839451 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 805185
issue 819212



Sign in to add a comment

Bookmarks: Implement new styling for BookmarkFolderViewController

Project Member Reported by rohitrao@chromium.org, May 3 2018

Issue description

Create new cells to implement the UIRefresh UI for the folder selection screen.  We can continue to use the existing items, just simply give them a different cellClass.
 
Labels: small
Blocking: 819212
NextAction: 2018-05-23
Status: Started (was: Assigned)

Comment 5 by sczs@chromium.org, May 18 2018

Cc: -sczs@chromium.org rohitrao@chromium.org
Owner: sczs@chromium.org
Talked with Rohit and I'll be taking this one. Will upload a CL soon, only needs some cleaning up.
Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/008cb81ff038be4d0173dd2fe10bb505304b17e5

commit 008cb81ff038be4d0173dd2fe10bb505304b17e5
Author: sczs <sczs@chromium.org>
Date: Tue May 22 20:06:00 2018

[ios] Changes BookmarkFolderVC style to UIRefresh.

- Adds the new Folder assets. (For the regular folder I replaced some un-used assets)
- Changes BookmarkFolderVC to match the UIRefresh styling.
- Creates TableViewBookmarkFolderCell with the UIRefresh styling.

Screenshot:
https://drive.google.com/open?id=1Pq5CtxhnfjA3FDyWEN-E4KzE43kJt0LZ

Bug:  839451 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia76fd4173f5f1c4f9ff9e75a4e87b675d20c81c2
Reviewed-on: https://chromium-review.googlesource.com/1066939
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560746}
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.h
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.mm
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.h
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.mm
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/BUILD.gn
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_folder.imageset/bookmark_blue_folder.png
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_folder.imageset/bookmark_blue_folder@2x.png
[modify] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_folder.imageset/bookmark_blue_folder@3x.png
[add] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_new_folder.imageset/Contents.json
[add] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_new_folder.imageset/bookmark_blue_new_folder.png
[add] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_new_folder.imageset/bookmark_blue_new_folder@2x.png
[add] https://crrev.com/008cb81ff038be4d0173dd2fe10bb505304b17e5/ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_new_folder.imageset/bookmark_blue_new_folder@3x.png

Comment 7 by sczs@chromium.org, May 23 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-05-23

Sign in to add a comment