Switch to subclassing ChromeTableViewController. ChromeTableViewController will need to be updated to work with MDCAppBar.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d4ada0604de844a1c5206e5f17e3584ce83eec8 commit 6d4ada0604de844a1c5206e5f17e3584ce83eec8 Author: Rohit Rao <rohitrao@chromium.org> Date: Thu May 03 22:35:42 2018 [ios] Adds MDCAppBar support to ChromeTableViewController. Initially appbar support was added to SettingsRootTableViewController, as that was the only view controller which needed it. But now, we expect to support MDCAppBar in bookmarks screens as well, so this CL moves it to a common base class. We follow the pattern set by CollectionViewController and include an appBarStyle parameter which determines whether or not an MDCAppBar is created. BUG= 839439 , 839450 , 839460 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I057b15113987d91451ca3a104aba95dd17667cda Reviewed-on: https://chromium-review.googlesource.com/1043006 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#555892} [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/history/history_table_view_controller.h [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.h [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.h [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.h [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/BUILD.gn [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm [modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/chrome_table_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a09748a8f4eec7a33a40494141d770c36e1d4170 commit a09748a8f4eec7a33a40494141d770c36e1d4170 Author: sczs <sczs@chromium.org> Date: Wed May 09 23:03:24 2018 [ios] BookmarkFolderVC subclasses ChromeTableVC. - BookmarkFolderVC now subclasses ChromeTableVC. - BookmarkFolderVC uses a tableViewModel. - Moves BookmarkFolderTableViewCell inside BookmarkFolderItem. Screenshots Old: https://drive.google.com/open?id=1JHQHVToYnKeTGPDGdDXKtBhLQ8C1S_26 New: https://drive.google.com/open?id=1yTIY9QUqaYlXkFd5kXnt720HsTfpDfJk BUG= 839448 , 839450 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I39722b4383d43174f9e944c26c08a753db527d56 Reviewed-on: https://chromium-review.googlesource.com/1051045 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#557366} [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/BUILD.gn [delete] https://crrev.com/e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.h [delete] https://crrev.com/e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/cells/BUILD.gn [add] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.h [add] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.mm
This is fixed now?
Yes, its fixed!
Comment 1 by rohitrao@chromium.org
, May 3 2018