Issue metadata
Sign in to add a comment
|
Bookmarks: Convert BookmarkFolderViewController to use TableViewModel |
||||||||||||||||||||||
Issue descriptionThis UI is already built on top of UITableViewController, but it uses a std::vector<BookmarkNode> as its model. Instead, we should switch to use TableViewModel. We will need to create BookmarkFolderDefaultItem and BookmarkFolderNodeItem classes that are associated with BookmarkFolderTableViewCell. This will help ease the transition to ChromeTableViewController.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a09748a8f4eec7a33a40494141d770c36e1d4170 commit a09748a8f4eec7a33a40494141d770c36e1d4170 Author: sczs <sczs@chromium.org> Date: Wed May 09 23:03:24 2018 [ios] BookmarkFolderVC subclasses ChromeTableVC. - BookmarkFolderVC now subclasses ChromeTableVC. - BookmarkFolderVC uses a tableViewModel. - Moves BookmarkFolderTableViewCell inside BookmarkFolderItem. Screenshots Old: https://drive.google.com/open?id=1JHQHVToYnKeTGPDGdDXKtBhLQ8C1S_26 New: https://drive.google.com/open?id=1yTIY9QUqaYlXkFd5kXnt720HsTfpDfJk BUG= 839448 , 839450 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I39722b4383d43174f9e944c26c08a753db527d56 Reviewed-on: https://chromium-review.googlesource.com/1051045 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#557366} [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/BUILD.gn [delete] https://crrev.com/e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.h [delete] https://crrev.com/e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm [modify] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/cells/BUILD.gn [add] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.h [add] https://crrev.com/a09748a8f4eec7a33a40494141d770c36e1d4170/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.mm
,
May 15 2018
This is fixed now?
,
May 15 2018
Yes, its fixed! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rohitrao@chromium.org
, May 9 2018NextAction: 2018-05-09
Owner: sczs@chromium.org
Status: Started (was: Assigned)