New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839447 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature



Sign in to add a comment

[GN] Add depsformat and description options to action and action_foreach targets

Reported by samo...@gmail.com, May 3 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. Create action target with depsformat or description options

What is the expected behavior?

What went wrong?
Options are not recognized and passed to ninja, despite ninja can support it

Did this work before? No 

Chrome version: 66.0.3359.139  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

depsformat = "msvc" might be useful in various actions based on msvc toolchain: for example in our standalone project we have some includes from idl files, that are resolved on idl/tlb generation, and so tlb should be regenerated if included idls are changed. It is possible to write python wrapper to parse includes manually and generate depsfile, but this is tedious and and it is duplicated work, because midl.exe can accept additional preprocessor options and /showIncludes can be passed

description option isn't very useful for single actions, and it won't influence build results, but it may make build progress more neat if a lot of action templates is used
 
Labels: Needs-Triage-M66
Components: Blink>Bindings
Labels: M-68 Triaged-ET FoundIn-68 Target-68
Status: Untriaged (was: Unconfirmed)
The issue seems to be a feature request. Hence, marking it as untriaged for further inputs from dev team.

Thanks...!!
Cc: brettw@chromium.org
Components: -Blink>Bindings Build
Labels: -Pri-2 Pri-3
This is not a bindings bug, it's a GN feature request.
Cc: thakis@chromium.org
Cc: dpranke@chromium.org
[mac bug triage] cc'ing thakis@ and dpranke@ to figure out how to handle this
See also issue 838340.
Labels: Build-Tools-GN
Labels: -M-68 -Triaged-ET -FoundIn-68 -Target-68 -Needs-Triage-M66
Status: Available (was: Untriaged)
Clearing all the release-oriented labels, since this has nothing to do with those.

Sign in to add a comment