New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839444 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Save build and try job urls from GetIsolatShaPipeline

Project Member Reported by lijeffrey@chromium.org, May 3 2018

Issue description

When getting the isolated hash for commit positions, information such as the build or try job urls can be retrieved but are never stored.

Need to keep track of where the isolated hashes came from, be they builds on the waterfall or the result of flake try jobs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0

commit b40a4b4a372e328082d0d6eb6fe8328d96cc20f0
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu May 03 22:53:07 2018

[Findit] Flake Analyzer - Save build and try job urls to data points

This change removes the dependency of Flake Analyzer's saving data points
needing any build-level information. Instead of getting it when creating
data points, it is retrieved when the isolate sha is generated and propagated
down to updating data points.

Bug: 839444
Change-Id: I35fe185263e1ba7120399fbeb8e4f3d2aecd3b07
Reviewed-on: https://chromium-review.googlesource.com/1042504
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/services/flake_failure/data_point_util.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/test/update_flake_analysis_data_points_pipeline_test.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/test/determine_approximate_pass_rate_pipeline_test.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/services/flake_failure/test/data_point_util_test.py
[add] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/dto/update_flake_analysis_data_points_input.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/determine_approximate_pass_rate_pipeline.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/waterfall/flake/test/next_build_number_pipeline_test.py
[modify] https://crrev.com/b40a4b4a372e328082d0d6eb6fe8328d96cc20f0/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py

Status: Verified (was: Assigned)

Comment 4 by st...@chromium.org, May 17 2018

Status: Assigned (was: Verified)
Reopen.

Sign in to add a comment