New issue
Advanced search Search tips

Issue 839442 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 805166
issue 819212



Sign in to add a comment

Bookmarks: Implement new styling for BookmarkHomeViewController

Project Member Reported by rohitrao@chromium.org, May 3 2018

Issue description

Implement the new styling for cells in the main bookmarks list.  This will involve switching to TableViewURLCell under UIRefresh but continuing to use the same BookmarkNodeItem.
 
Blocking: 819212
NextAction: 2018-05-23
Project Member

Comment 3 by sheriffbot@chromium.org, May 18 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by sczs@chromium.org, May 23 2018

Cc: -sczs@chromium.org rohitrao@chromium.org
Owner: sczs@chromium.org
Status: Started (was: Assigned)
The NextAction date has arrived: 2018-05-23

Comment 6 by sczs@chromium.org, May 23 2018

Labels: -small medium
NextAction: 2018-06-06
This is probably going to need some refactoring. Changing size from small to medium
Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11cca8953748a510bb982d39aedd171f2c7be62a

commit 11cca8953748a510bb982d39aedd171f2c7be62a
Author: sczs <sczs@chromium.org>
Date: Thu May 31 17:08:24 2018

[iOS] Styles BookmarkHomeVC for UIRefresh.

Screenshots:
https://drive.google.com/open?id=1Y5SrS0fznYQ1HRtiyydtYrFejtcO5qbB
https://drive.google.com/open?id=1UeIyvQTAkmkDEQcMVAuCoh8cUWCK_d2T

Bug:  839442 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1f65dc7ce24307e82c4246b4da2776e92d8df9d8
Reviewed-on: https://chromium-review.googlesource.com/1074557
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563286}
[modify] https://crrev.com/11cca8953748a510bb982d39aedd171f2c7be62a/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/11cca8953748a510bb982d39aedd171f2c7be62a/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.h
[modify] https://crrev.com/11cca8953748a510bb982d39aedd171f2c7be62a/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.mm
[modify] https://crrev.com/11cca8953748a510bb982d39aedd171f2c7be62a/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_node_item.mm
[modify] https://crrev.com/11cca8953748a510bb982d39aedd171f2c7be62a/ios/chrome/browser/ui/table_view/table_view_navigation_controller.mm

Project Member

Comment 8 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d07a1fe9b60aff0e69151ea8a008992b233e2f9

commit 6d07a1fe9b60aff0e69151ea8a008992b233e2f9
Author: sczs <sczs@chromium.org>
Date: Thu May 31 19:32:27 2018

[ios] Adds title editing support to TableViewBookmarkFolderCell.

- Changes TableViewBookmarkFolderCell label for a textField and adds editing support.
- Creates bookmark_table_cell_title_edit_delegate to handle text changes from both legacy and non
legacy cells.
- Creates bookmark_table_cell_title_editing so both legacy and non legacy cells have the
same public interface, this way shared_state won't depend on TableViewCell.

Screenshot:
https://drive.google.com/open?id=1KDHPDj8lFfHAitI2gL9qLjxOi77KlPvW

Bug:  839442 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3d43501c93200d690664a26694cc1ac3d9e41f04
Reviewed-on: https://chromium-review.googlesource.com/1074760
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563347}
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.h
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/BUILD.gn
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.h
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_folder_item.mm
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_node_item.mm
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.h
[modify] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.mm
[add] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell_title_edit_delegate.h
[add] https://crrev.com/6d07a1fe9b60aff0e69151ea8a008992b233e2f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell_title_editing.h

Comment 9 by sczs@chromium.org, Jun 4 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-06-06

Sign in to add a comment