Issue metadata
Sign in to add a comment
|
init: reports of "Undeclared imported variable" |
||||||||||||||||||||||
Issue descriptionLooking at a ramoops, I notice some warnings from init: grep "Undeclared imported variable" console-ramoops-0 [ 4.248159] init: midis: Undeclared imported variable CHROMEOS_DEV_MODE=1 [ 4.248177] init: midis: Undeclared imported variable CHROMEOS_INSIDE_VM=0 [ 4.248187] init: midis: Undeclared imported variable NATIVE_BRIDGE_EXPERIMENT=1 [ 4.248268] init: arc-lifetime: Undeclared imported variable CHROMEOS_DEV_MODE=1 [ 4.248279] init: arc-lifetime: Undeclared imported variable CHROMEOS_INSIDE_VM=0 [ 4.248289] init: arc-lifetime: Undeclared imported variable NATIVE_BRIDGE_EXPERIMENT=1 [ 4.248373] init: arc-ureadahead: Undeclared imported variable CHROMEOS_DEV_MODE=1 [ 4.248384] init: arc-ureadahead: Undeclared imported variable CHROMEOS_INSIDE_VM=0 [ 4.248393] init: arc-ureadahead: Undeclared imported variable NATIVE_BRIDGE_EXPERIMENT=1 [ 14.926057] init: login: Undeclared imported variable CHROMEOS_USER=gwendal@gmail.com [ 14.926203] init: shill-start-user-session: Undeclared imported variable CHROMEOS_USER=gwendal@gmail.com [ 14.926338] init: machine-info: Undeclared imported variable CHROMEOS_USER=gwendal@gmail.com The warning can be silenced by adding import <variable_name> in the proper .conf. For instance, in arc-lifetime, I don't see a direct use of NATIVE_BRIDGE_EXPERIMENT but it is used in arc_setup, called by arc-lifetime via exec.
,
May 31 2018
The CLs I sent removed some of the warnings. There are some false positives though because of jobs receiving variables that they actually don't require (for example, CHROMEOS_USER is present on the start-user-session event, but not all jobs triggered by it do actually consume it. I've meanwhile downgraded the warning to info. I plan to leave this present for a couple weeks for the event that it is helpful, then remove it unless I hear evidence of the log output actually being useful to anyone.
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/73cd5ab3d50a00b5083049437cd76c0c435f3c18 commit 73cd5ab3d50a00b5083049437cd76c0c435f3c18 Author: Mattias Nissler <mnissler@chromium.org> Date: Thu Jun 14 16:47:43 2018 sys-apps/upstart: Drop warning on unimported external env vars The warning was intended to help developers in the transition period. I have zero evidence that it helped, and a couple complaints about the false positives it generates, so let's drop it. BUG= chromium:839441 TEST=Builds, no more "Ignoring environment variable" warnings in syslog Change-Id: Id143889a2c9f415c7789dec8078458d1e9d282f2 Reviewed-on: https://chromium-review.googlesource.com/1098963 Commit-Ready: Mattias Nissler <mnissler@chromium.org> Tested-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/73cd5ab3d50a00b5083049437cd76c0c435f3c18/sys-apps/upstart/upstart-1.2-r27.ebuild [modify] https://crrev.com/73cd5ab3d50a00b5083049437cd76c0c435f3c18/sys-apps/upstart/files/upstart-1.2-import-env.patch
,
Jun 25 2018
The NextAction date has arrived: 2018-06-25
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 8
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gwendal@chromium.org
, May 4 2018