New issue
Advanced search Search tips

Issue 839440 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[GN] Generated xcode project don't index symbols because of lack of include_dirs

Reported by samo...@gmail.com, May 3 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. Use relative includes
2. Add include_dirs to target
3. Run gn gen out/Default --ide=xcode
4. Open Xcode project and cmd-click on relative include

What is the expected behavior?
Xcode will open included file

What went wrong?
Nothing happends

Did this work before? N/A 

Chrome version: 66.0.3359.139  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

INC or INC should be set according to include_dirs.

As Xcode project uses separate target for source indexing, it isn't obvious what include_dirs option should be used. In our standalone project we have several Include folders that is set in default configs for all targets - at least such default options should be applied to sources target
Better solution might be to collect include_dirs from all targets that is used for project generation. It may also be easier to implement, but may have performance impact in generated project usage. Maybe even additional filter cli option should be added to specify from which targets include_dirs should be collected
 
Labels: Needs-Triage-M66
Components: Build
Labels: Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to code. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!

Comment 3 by lgrey@chromium.org, May 7 2018

Status: Available (was: Unconfirmed)

Sign in to add a comment