New issue
Advanced search Search tips

Issue 839439 link

Starred by 1 user
Status: Fixed
Owner:
rohitrao@chromium.org
Closed: May 2018
Cc:
sczs@chromium.org
thegreenfrog@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 805166



Sign in to add a comment

Bookmarks: Convert BookmarkHomeViewController to subclass ChromeTableViewController

Project Member Reported by rohitrao@chromium.org, May 3 2018 
BookmarkHomeViewController should become a subclass of ChromeTableViewController.  Code that owns a TableViewModel and implements UITableViewDataSource can be deleted when this happens.

ChromeTableViewController will likely need to be updated to work with MDCAppBar, as that is necessary for the old UI.
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d4ada0604de844a1c5206e5f17e3584ce83eec8

commit 6d4ada0604de844a1c5206e5f17e3584ce83eec8
Author: Rohit Rao <rohitrao@chromium.org>
Date: Thu May 03 22:35:42 2018

[ios] Adds MDCAppBar support to ChromeTableViewController.

Initially appbar support was added to SettingsRootTableViewController,
as that was the only view controller which needed it.  But now, we
expect to support MDCAppBar in bookmarks screens as well, so this CL
moves it to a common base class.  We follow the pattern set by
CollectionViewController and include an appBarStyle parameter which
determines whether or not an MDCAppBar is created.

BUG= 839439 , 839450 , 839460 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I057b15113987d91451ca3a104aba95dd17667cda
Reviewed-on: https://chromium-review.googlesource.com/1043006
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555892}
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/history/history_table_view_controller.h
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.h
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.h
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/BUILD.gn
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
[modify] https://crrev.com/6d4ada0604de844a1c5206e5f17e3584ce83eec8/ios/chrome/browser/ui/table_view/chrome_table_view_controller_unittest.mm

Comment 2 by rohitrao@chromium.org, May 14 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb526bb53f0399662a2c9d5bd3889257b52907f9

commit cb526bb53f0399662a2c9d5bd3889257b52907f9
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon May 14 22:02:56 2018

[ios] Deletes BookmarkTableView.

Makes BookmarkHomeViewController subclass UITableViewController instead of
UIViewController. Moves the loading spinner and empty background view into
BookmarkHomeViewController.


BUG= 840381 , 839439 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I935a99313eb3aa7f8701d46d803bea575e5bc89a
Reviewed-on: https://chromium-review.googlesource.com/1056328
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558484}
[modify] https://crrev.com/cb526bb53f0399662a2c9d5bd3889257b52907f9/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/cb526bb53f0399662a2c9d5bd3889257b52907f9/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h
[modify] https://crrev.com/cb526bb53f0399662a2c9d5bd3889257b52907f9/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/cb526bb53f0399662a2c9d5bd3889257b52907f9/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[delete] https://crrev.com/ee749a4e70158c219fd83fd25e3a39b707de7bde/ios/chrome/browser/ui/bookmarks/bookmark_table_view.h
[delete] https://crrev.com/ee749a4e70158c219fd83fd25e3a39b707de7bde/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm
[modify] https://crrev.com/cb526bb53f0399662a2c9d5bd3889257b52907f9/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_promo_item.mm
Project Member

Comment 4 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7667ca1e59d36769f7f323c5ed35d62a7ca219f2

commit 7667ca1e59d36769f7f323c5ed35d62a7ca219f2
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue May 15 01:01:30 2018

[ios] Has BookmarkHomeViewController subclass ChromeTableViewController.

BUG= 839439 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5bc6aea6c46d7c25808e3924f9ca45f8452682a5
Reviewed-on: https://chromium-review.googlesource.com/1057457
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558563}
[modify] https://crrev.com/7667ca1e59d36769f7f323c5ed35d62a7ca219f2/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.h
[modify] https://crrev.com/7667ca1e59d36769f7f323c5ed35d62a7ca219f2/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.mm
[modify] https://crrev.com/7667ca1e59d36769f7f323c5ed35d62a7ca219f2/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h
[modify] https://crrev.com/7667ca1e59d36769f7f323c5ed35d62a7ca219f2/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

Comment 5 by rohitrao@chromium.org, May 15 2018

Status: Fixed (was: Started)

Comment 6 by rohitrao@chromium.org, May 15 2018

NextAction: 2018-05-23

Comment 7 by monor...@bugs.chromium.org, May 23 2018 

The NextAction date has arrived: 2018-05-23
►

Sign in to add a comment