New issue
Advanced search Search tips

Issue 839431 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 692728
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Deprecate and remove File.lastModifiedDate

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, May 3 2018

Issue description

WPT import https://crrev.com/c/1042207 introduced new failures in external/wpt/FileAPI:

List of new failures:
external/wpt/FileAPI/historical.https.html new failing tests: https://crrev.com/c/1042207/4/third_party/WebKit/LayoutTests/external/wpt/FileAPI/historical.https-expected.txt

This import contains upstream changes from b5befcbe4803b7de1a758142a675a1eae60c1bac to 95127fa5adb1d9953899561c152c518c552e4ed0:
File API: lastModifiedDate has been obsolete for a while: https://github.com/w3c/web-platform-tests/commit/95127fa5adb1d9953899561c152c518c552e4ed0 [affecting this directory]
Hook up logging for websocket server: https://github.com/w3c/web-platform-tests/commit/f4dfd5fb5f8dda5ba6974c791d153d968edf0aa3

 
Components: Blink>Storage>FileAPI
Components: -Blink>FileAPI

Comment 3 by pwnall@chromium.org, Jun 18 2018

Cc: -mek@chromium.org pwnall@chromium.org
Labels: Pri-2 Type-Bug
Owner: mek@chromium.org
Status: Assigned (was: Untriaged)
Summary: Deprecate and remove File.lastModifiedDate (was: [WPT] New failures introduced in external/wpt/FileAPI by import https://crrev.com/c/1042207)
Fixing the WPT failure entails deprecating and removing File.lastModifiedDate, so I have updated the bug title.

https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/fileapi/file.idl lists lastModifiedDate as a non-standard feature, and we have a use counter for it. The values don't seem awfully high. https://www.chromestatus.com/metrics/feature/timeline/popularity/212

mek@: WDYT about deprecating and removing lastModifiedDate?

Comment 4 by mek@chromium.org, Jun 18 2018

Mergedinto: 692728
Status: Duplicate (was: Assigned)

Sign in to add a comment