New issue
Advanced search Search tips

Issue 839427 link

Starred by 1 user
Status: Fixed
Owner:
rohitrao@chromium.org
Closed: May 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-09
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 805166



Sign in to add a comment

Bookmarks: Move TableViewModel up into BookmarkHomeViewController

Project Member Reported by rohitrao@chromium.org, May 3 2018 
The TableViewModel is currently owned by BookmarksTableView.  Move it up into BookmarkHomeViewController instead.  The VC can then become the data source for the table view.

This lays the groundwork for eventually converting BookmarkHomeViewController into a ChromeTableViewController subclass.
Project Member

Comment 1 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf8e840d97fc0c4d149106cc0ff9d6537144f73e

commit bf8e840d97fc0c4d149106cc0ff9d6537144f73e
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon May 07 16:56:24 2018

[ios] Introduces BookmarkHomeSharedState.

An upcoming refactoring will move methods out of BookmarkTableView and into
BookmarkHomeViewController or BookmarkHomeMediator. To ease this transition, we
introduce a data structure that holds various ivars that used to be in
BookmarkTableView.

BUG= 839427 , 840381 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaeb854e3a5cc243e90dd6b5a6e15e70f679728f6
Reviewed-on: https://chromium-review.googlesource.com/1047365
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556471}
[modify] https://crrev.com/bf8e840d97fc0c4d149106cc0ff9d6537144f73e/ios/chrome/browser/ui/bookmarks/BUILD.gn
[add] https://crrev.com/bf8e840d97fc0c4d149106cc0ff9d6537144f73e/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.h
[add] https://crrev.com/bf8e840d97fc0c4d149106cc0ff9d6537144f73e/ios/chrome/browser/ui/bookmarks/bookmark_home_shared_state.mm
[modify] https://crrev.com/bf8e840d97fc0c4d149106cc0ff9d6537144f73e/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/bf8e840d97fc0c4d149106cc0ff9d6537144f73e/ios/chrome/browser/ui/bookmarks/bookmark_table_view.h
[modify] https://crrev.com/bf8e840d97fc0c4d149106cc0ff9d6537144f73e/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm

Comment 2 by rohitrao@chromium.org, May 9 2018

Status: Fixed (was: Assigned)

Comment 3 by rohitrao@chromium.org, May 9 2018

NextAction: 2018-05-09
►

Sign in to add a comment