New issue
Advanced search Search tips

Issue 839424 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 771643



Sign in to add a comment

When printing, fixed elements only appear on first page if "transform:rotate"

Reported by valentin...@gmail.com, May 3 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Example URL:

Steps to reproduce the problem:
1. 
Make a HTML page with the following content (or get the page attached):

<body style="height: 1200px">
  <p style="position: fixed; top: 0;transform:rotate(1deg)">
    Hello !
  </p>
</body>

2. Open the page in Chromium 67 and ask "print".

What is the expected behavior?
 You should see a print preview with 2 pages, each containing the world "Hello"

This is the behaviour "natural" behaviour observed in Firefox, and Chromium up to 65, (66 not tested).

What went wrong?
In Chromium 67, "Hello" will only appear on the first page. This seems due to the presence of "transform:rotate(1deg)", as when you remove this you get "Hello" on every page.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes 65 (or 66, not tested)

Does this work in other browsers? Yes

Chrome version: 67.0.3391.0  Channel: n/a
OS Version: Ubuntu 16.04
Flash Version: Shockwave Flash 13.1 r2

Reproduced by other people on other systems. Here is the related Github issue (where Chromium is used through other software).

https://github.com/RelaxedJS/ReLaXed/issues/17
 
page.html
111 bytes View Download
Components: Internals>Printing
Labels: Needs-Bisect Needs-Triage-M67
Cc: phanindra.mandapaka@chromium.org
Labels: -Pri-2 -Type-Compat -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 Target-68 FoundIn-68 Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported version 66.0.3359.139 and latest chrome M68 #68.0.3419.0 using Mac 10.12.6,Ubuntu 14.04 and Win10.hence providing bisect information below.

Bisect Info:
================
Good build: 67.0.3371.0 
Bad build: 67.0.3372.0

You are probably looking for a change made after 543290 (known good), but no later than 543291 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/63667eca2a1d86f5de61f29c7c5c6417cc351757..3a3c78a924a686ed0d3f90d765b00cdd78453e11

suspect: https://chromium.googlesource.com/chromium/src/+/3a3c78a924a686ed0d3f90d765b00cdd78453e11

Reviewed-on: https://chromium-review.googlesource.com/923572

@wangxianzhu: Please confirm the issue and help in re-assigning if it is not related to your change.Adding RB-Stable lable please remove if not required.


Thanks!
Labels: OS-Mac OS-Windows
Blocking: 771643
Components: Blink>Paint
Labels: Needs-Feedback
Fixing this bug in M-68 may require a non-trivial change. We will evaluation the risk of the change to determine if we will merge it back to M-67.

Before the bug is fixed, please try the method shown in the attached test case to workaround https://github.com/RelaxedJS/ReLaXed/issues/17.

page-vrl.html
136 bytes View Download
Labels: -Needs-Feedback
Thank you for the help. The proposed workaround, which uses "writing-mode: vertical-rl;" works for my example (i.e. for the PDF report discussed in the Github issue, where the element is a sidebar with text), and is a big improvement.

However it is not perfect, in the sense that "writing-mode: vertical-rl" rotates the text by a 90deg angle (it reads from top to bottom), while ideally I would want the text to be rotated -90deg (so that the beginning is at the bottom). I also tried "writing-mode: vertical-rl" but it doesnt solve that problem (I dont really understand what it changes, the text is still top to bottom).


*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74

commit 47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue May 08 02:57:58 2018

[SPv175] FragmentData based fixed-position repeating in paged media

The old PaintLayerFragment based fixed-position repeating method works
for the existing printing/fixed-position*.html tests, but doesn't work
for transformed fixed-position because we use FragmentData to find
the proper paint offset in the case.

Now generate FragmentData for repeating fixed-position in paged media.

Bug:  839424 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2dee12ef502488a0a3683d2b3d81ecbca38e4b5b
Reviewed-on: https://chromium-review.googlesource.com/1045560
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556657}
[modify] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/mac-mac10.12/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/threaded/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/win/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/platform/win/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/WebKit/LayoutTests/printing/fixed-positioned-headers-and-footers-transformed.html
[modify] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/blink/renderer/core/paint/adjust_paint_offset_scope.cc
[modify] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/blink/renderer/core/paint/paint_property_tree_builder.h
[modify] https://crrev.com/47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc

How is the change listed at #10 looking in canary? Is it safe to merge with enough automation tests coverage?
Labels: Merge-Request-67
Verified in 68.0.3425.0. The CL affects fixed-position elements in printing only, and the tests covers enough cases, so it's safe to merge.

Project Member

Comment 13 by sheriffbot@chromium.org, May 9 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #12. Pls merge ASAP and mark teh bug as fixed after the merge if nothing else is pending. Thank you.
Project Member

Comment 15 by bugdroid1@chromium.org, May 9 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9e18b9bf0eb43e070aae7294e481340deb4ba0

commit be9e18b9bf0eb43e070aae7294e481340deb4ba0
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed May 09 22:36:18 2018

[SPv175] FragmentData based fixed-position repeating in paged media

The old PaintLayerFragment based fixed-position repeating method works
for the existing printing/fixed-position*.html tests, but doesn't work
for transformed fixed-position because we use FragmentData to find
the proper paint offset in the case.

Now generate FragmentData for repeating fixed-position in paged media.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 47bdcd0c5b0765fa4131e162fd74ed3f64d8ae74)

Bug:  839424 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2dee12ef502488a0a3683d2b3d81ecbca38e4b5b
Reviewed-on: https://chromium-review.googlesource.com/1045560
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556657}
Reviewed-on: https://chromium-review.googlesource.com/1053269
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#540}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/mac-mac10.12/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/threaded/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/win/printing/fixed-positioned-headers-and-footers-transformed-expected.png
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/platform/win/printing/fixed-positioned-headers-and-footers-transformed-expected.txt
[add] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/WebKit/LayoutTests/printing/fixed-positioned-headers-and-footers-transformed.html
[modify] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/blink/renderer/core/paint/adjust_paint_offset_scope.cc
[modify] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/blink/renderer/core/paint/paint_property_tree_builder.h
[modify] https://crrev.com/be9e18b9bf0eb43e070aae7294e481340deb4ba0/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment