Issue metadata
Sign in to add a comment
|
Bookmarks: Convert BookmarksTableView to use TableViewModel |
||||||||||||||||||||||
Issue descriptionBookmarksTableView currently uses a std::vector<BookmarkNode*> as its backing array. Switch to use TableViewModel instead, as this will make it easier to migrate to ChromeTableViewController in the future. Create a BookmarkNodeItem that simply wraps a BookmarkNode for now, and continue to use the existing BookmarkTableCell.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc91ad5a12d8b021d6be297f366146c654487f5 commit fbc91ad5a12d8b021d6be297f366146c654487f5 Author: Rohit Rao <rohitrao@chromium.org> Date: Fri May 04 02:04:17 2018 [ios] Converts BookmarkTableView to use TableViewModel. Switches to TableViewModel instead of a std::vector of BookmarkNodes. BUG= 839423 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b12b1c22f6f0d229eed79da407df2443081bbfe Reviewed-on: https://chromium-review.googlesource.com/1042349 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555959} [modify] https://crrev.com/fbc91ad5a12d8b021d6be297f366146c654487f5/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/fbc91ad5a12d8b021d6be297f366146c654487f5/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm [modify] https://crrev.com/fbc91ad5a12d8b021d6be297f366146c654487f5/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.h [modify] https://crrev.com/fbc91ad5a12d8b021d6be297f366146c654487f5/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.mm [modify] https://crrev.com/fbc91ad5a12d8b021d6be297f366146c654487f5/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_signin_promo_cell.mm
,
May 7 2018
,
May 9 2018
The NextAction date has arrived: 2018-05-09 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rohitrao@chromium.org
, May 3 2018