New issue
Advanced search Search tips

Issue 839415 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 719312



Sign in to add a comment

Swarming: Refactor quarantined into unhealthy, add unhealthy_msg as a string to BotInfo

Project Member Reported by mar...@chromium.org, May 3 2018 
- Rename quarantined to unhealthy. Make it a string (hence _msg) to explain why it is unhealthy.
- Add quarantine_msg for server-side quarantine to solve issue 719312.

This means quarantined changes meaning.

This requires a fair amount of refactoring:
- API needs an overhaul.
- Web UI.
- Bot should use 'unhealthy' for their state. It should be in state only, not in dimensions, in part to help with issue 786734.
- Customers need to update their usage.
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/a9a507cbc46067e1df48964bc603e39c2e009906

commit a9a507cbc46067e1df48964bc603e39c2e009906
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu May 03 15:56:07 2018

Disable indexing on BotInfo 'quarantined' field

Since composite is now the reference, indexing with quarantined is not
needed anymore and this will be a small performance boost.

Context: https://goo.gl/9HkuUg

Bug: 839415
Change-Id: I92ade431ed664e3b4bb9c7379e8a8ed5526e3366
Reviewed-on: https://chromium-review.googlesource.com/1042533
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/a9a507cbc46067e1df48964bc603e39c2e009906/appengine/swarming/server/bot_management.py
►

Sign in to add a comment