New issue
Advanced search Search tips

Issue 839402 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove currencySystem member in PaymentCurrencyAmount

Project Member Reported by jinho.b...@samsung.com, May 3 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f84d4e6d97ff2a1b46f0650c6546b523fb23afa5

commit f84d4e6d97ff2a1b46f0650c6546b523fb23afa5
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu May 10 12:50:00 2018

PaymentRequest: Add a use counter to count invalid currency code

This patch adds a use counter to count invalid currency code.
The data will be used later when deprecating/removing the member.

Bug:  839402 
Change-Id: Idbb4f305cf453a3ddddf19983ecfb45bec69d22d
Reviewed-on: https://chromium-review.googlesource.com/1053027
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#557497}
[modify] https://crrev.com/f84d4e6d97ff2a1b46f0650c6546b523fb23afa5/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc
[modify] https://crrev.com/f84d4e6d97ff2a1b46f0650c6546b523fb23afa5/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/f84d4e6d97ff2a1b46f0650c6546b523fb23afa5/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/f84d4e6d97ff2a1b46f0650c6546b523fb23afa5/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b0ea43e0fcda2265aa718e784d00b545db36ef

commit 26b0ea43e0fcda2265aa718e784d00b545db36ef
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu May 24 01:09:04 2018

PaymentRequest: Remove `currencySystem` member

After a long discussion, Web Payment Working Group decided to remove
the `currencySystem` member[1]. The currency code should be well-formed
3-letter alphabetic code and is allowed even if that is not part of
the official ISO 4217 list.

[1] https://github.com/w3c/payment-request/pull/694

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-jtNNH_Bb6c

Bug:  839402 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I17ac51c93e457c4bae00db365a4c7322274c8d4f
Signed-off-by: Jinho Bang <jinho.bang@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/1042427
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561348}
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/chrome/android/javatests/src/org/chromium/chrome/browser/payments/CurrencyFormatterTest.java
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/chrome/browser/android/payments/service_worker_payment_app_bridge.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/content/android/currency_formatter_android.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/content/android/currency_formatter_android.h
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/content/android/java/src/org/chromium/components/payments/CurrencyFormatter.java
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/content/payment_request_spec.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/content/payment_request_spec.h
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/currency_formatter.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/currency_formatter.h
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/currency_formatter_unittest.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payment_currency_amount.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payment_currency_amount_unittest.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payment_details_modifier_unittest.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payment_details_validation.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payment_item_unittest.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payments_validators.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payments_validators.h
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/core/payments_validators_unittest.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/components/payments/mojom/payment_request_data.mojom
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/ios/chrome/browser/web/resources/payment_request.js
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/public/platform/modules/payments/web_payment_currency_amount.h
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payment_currency_amount.idl
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payment_event_data_conversion.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payment_request_details_test.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payment_test_helper.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payment_test_helper.h
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payments_validators.cc
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payments_validators.h
[modify] https://crrev.com/26b0ea43e0fcda2265aa718e784d00b545db36ef/third_party/blink/renderer/modules/payments/payments_validators_test.cc

Status: Fixed (was: Started)

Sign in to add a comment