Swarming doesn't send pub/sub messages for de-duplicated tasks |
|
Issue descriptionSwarming doesn't send pub/sub messages for de-duplicated tasks This is causing slowness for Skia's task scheduler which relies on pub/sub to quickly notify us when tasks finish. Rather than saving us time, small (<2 minutes) tasks get de-duplicated, but we don't receive a pub/sub message, so we fall back on our 5-minute polling loop, which ends up with us waiting longer than if the task had actually run.
,
May 31 2018
The following revision refers to this bug: https://skia.googlesource.com/buildbot/+/a89d8f90f8bce15db2f1b071878569e8ec17ac57 commit a89d8f90f8bce15db2f1b071878569e8ec17ac57 Author: Eric Boren <borenet@google.com> Date: Thu May 31 11:21:42 2018 [task scheduler] Always set idempotent=false Unfortunately, idempotent enables automatic retries which we don't want. The tasks which do get de-duplicated (eg. isolating assets) are not noticed until our 5-minute polling loop, since Swarming does not yet send pub/sub notifications for those (see http://crbug.com/839395), so it'll probably actually be faster to run them. Bug: chromium:828390, chromium:839395 Change-Id: I0e0985d88ff35402beee3286d5da541648879067 Reviewed-on: https://skia-review.googlesource.com/130847 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com> [modify] https://crrev.com/a89d8f90f8bce15db2f1b071878569e8ec17ac57/task_scheduler/go/scheduling/task_candidate.go |
|
►
Sign in to add a comment |
|
Comment 1 by tandrii@chromium.org
, May 3 2018