IDL compiler: Re-architect IDL compiler for bindings |
||||||||||||||||||||||||||||||||||
Issue descriptionCurrent IDL compiler was originally designed and implemented in 2014, and had been updated on demands. The design was good at that time, but it is not for now. For example, it does not take components in consideration. Hence now it has tons of issues, and blocks many other developers works. A bad point is that some issues have workaround, and it makes some IDL files strange (or out of spec). We would like to fix (hopefully) all issues around IDL compiler with creating it again from scratch.
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 3 2018
,
May 7 2018
,
May 25 2018
,
May 25 2018
,
May 25 2018
,
May 25 2018
,
May 25 2018
,
May 25 2018
,
May 25 2018
,
May 25 2018
,
May 25 2018
,
Aug 31
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e40ebbe9930013ef396e75958ad4f5a0cb6fc269 commit e40ebbe9930013ef396e75958ad4f5a0cb6fc269 Author: Hitoshi Yoshida <peria@chromium.org> Date: Thu Nov 29 03:19:55 2018 IDL compiler: Do not parse in IDL collection We designed to parse IDL files at collecting per component, but we found it duplicates the work. This CL drops the parsing phase in collecting IDL information per files, and hence we collect IDL information as a collection of AST objects. This CL also updates GN dependency to enroll all IDL files including generated files in the output collections. Bug: 839389 Change-Id: Ic014c8081c214f23ffffe932db04d5023841a3d1 Reviewed-on: https://chromium-review.googlesource.com/c/1322669 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#612014} [modify] https://crrev.com/e40ebbe9930013ef396e75958ad4f5a0cb6fc269/third_party/blink/renderer/bindings/core/BUILD.gn [modify] https://crrev.com/e40ebbe9930013ef396e75958ad4f5a0cb6fc269/third_party/blink/renderer/bindings/modules/BUILD.gn [modify] https://crrev.com/e40ebbe9930013ef396e75958ad4f5a0cb6fc269/third_party/blink/renderer/bindings/scripts/generate_web_idl_collection.py [modify] https://crrev.com/e40ebbe9930013ef396e75958ad4f5a0cb6fc269/third_party/blink/renderer/bindings/scripts/scripts.gni [modify] https://crrev.com/e40ebbe9930013ef396e75958ad4f5a0cb6fc269/third_party/blink/renderer/bindings/scripts/web_idl/collection.py [modify] https://crrev.com/e40ebbe9930013ef396e75958ad4f5a0cb6fc269/third_party/blink/renderer/bindings/scripts/web_idl/collector.py [delete] https://crrev.com/673693d7ce4a970912881b85f707115a66bec37c/third_party/blink/renderer/bindings/scripts/web_idl/collector_test.py |
||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||||||
Comment 1 by peria@chromium.org
, May 3 2018