New issue
Advanced search Search tips

Issue 839384 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

History: “Clear Browsing Data…” button is not functional in search mode in history

Project Member Reported by vbarig...@chromium.org, May 3 2018

Issue description

App Version: 68.0.3417.0 canary
iOS Version: 11.4 beta 2, 10.3.3
Device: iPads, iPhones
URL: Chrome Settings -- History

Precondition:
Enable ui-refresh-phase-1 in chrome://flag

Steps to reproduce:
  1.  Open chrome canary.
  2.  Browse few sites to generate history.
  3.  Go to Menu --> History
  4.  Tap on “Search” type in the history window --> Tap on Search on keyboard.
  5.  Tap on “Clear Browsing data..” on the history window.

Observed results:
Notice that “Clear Browsing Data…” is not functional.

Expected results:
“Clear Browsing Data…” should be functional and the dialog window should be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA on M66
Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M67

Link to video/image: 

iPad - https://drive.google.com/file/d/1w8q5b2ahYdWmqSd7QXFUxZhcV2aKjWxU/view?usp=sharing

iPhone - https://drive.google.com/file/d/1f-bd6geSAc2_XnuugBTWE06jzo5AwVrQ/view?usp=sharing
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fe957661439348de1df56f6ae3002d6dad8826e

commit 2fe957661439348de1df56f6ae3002d6dad8826e
Author: sczs <sczs@chromium.org>
Date: Wed Jun 27 15:31:22 2018

[ios] Allows access to CBD from history while searching.

This was ported from the legacy implementation and its no longer needed now.

Bug:  839384 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia3edcfb790ec3567fb24b0ebbb02903d5788fec1
Reviewed-on: https://chromium-review.googlesource.com/1116285
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570782}
[modify] https://crrev.com/2fe957661439348de1df56f6ae3002d6dad8826e/ios/chrome/browser/ui/history/history_table_view_controller.mm

Comment 2 by sczs@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on M69.0.3480.0 canary
iOS: 11.4, 12
iPhoneX, iPad pro.

Sign in to add a comment