New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839379 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-08
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3: Suppressor too aggressive during double talk

Project Member Reported by gustaf@chromium.org, May 3 2018

Issue description

The AEC3 suppressor sometimes acts more aggressively than needed. This affects transparency during double talk or when the far-end is leaking echo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/0e6375e78b3317a27b366f7ee1a642595225c271

commit 0e6375e78b3317a27b366f7ee1a642595225c271
Author: Gustaf Ullberg <gustaf@webrtc.org>
Date: Fri May 04 11:02:14 2018

AEC3: Transparency improvements to the suppressor

This CL contains changes to the echo suppressor that improves the
transparency of AEC3.

- The comfort noise level is used as masker and the masking threshold is
increased.
- Suppression gains are allowed to increase more rapidly.
- Suppression gains decrease slower in the lower frequencies after strong
nearend.

Change-Id: I7adf31ed90b0e007072191f40439f27c3b0bccf2
Bug:  webrtc:9230 , chromium:839379 
Reviewed-on: https://webrtc-review.googlesource.com/73680
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Per Ã…hgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23115}
[modify] https://crrev.com/0e6375e78b3317a27b366f7ee1a642595225c271/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/0e6375e78b3317a27b366f7ee1a642595225c271/modules/audio_processing/aec3/BUILD.gn
[modify] https://crrev.com/0e6375e78b3317a27b366f7ee1a642595225c271/modules/audio_processing/aec3/suppression_gain.cc
[modify] https://crrev.com/0e6375e78b3317a27b366f7ee1a642595225c271/modules/audio_processing/aec3/suppression_gain.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db2fcf631b675eca1c62d6d102a8108a928c51c2

commit db2fcf631b675eca1c62d6d102a8108a928c51c2
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 04 14:45:09 2018

Roll src/third_party/webrtc/ a1f566b28..9d96e9231 (14 commits)

https://webrtc.googlesource.com/src.git/+log/a1f566b28a69..9d96e923169d

$ git log a1f566b28..9d96e9231 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:839379,chromium:836790,chromium:839351,chromium:637666,chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idaf4dcb114cbe96a981c6eba39aab8a3be42c19b
Reviewed-on: https://chromium-review.googlesource.com/1044265
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556050}
[modify] https://crrev.com/db2fcf631b675eca1c62d6d102a8108a928c51c2/DEPS

Status: Fixed (was: Started)
Cc: huib@chromium.org hlundin@chromium.org peah@chromium.org
Labels: -Pri-3 Merge-Request-67 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
We would like this to be merged to M67.

This code solves issues with transparency in AEC3 and fixes a regression in M67 where echo leakage in some cases could appear in the lower frequencies.

This is a well tested fix that is currently part of Canary since three days.

In the unlikely event of this code causing trouble, we have added a switch to be able to disable it remotely.

CL to merge:
https://webrtc-review.googlesource.com/c/src/+/73680

Project Member

Comment 5 by sheriffbot@chromium.org, May 7 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-67 Merge-Approved-67
Approvng merge for CL: 
https://webrtc-review.googlesource.com/c/src/+/73680 to M67 branch 3396 based on comment #4. Please merge ASAP so we can pick it up for this week beta Release. Thank you.
NextAction: 2018-05-08
Labels: Merge-Merged
Merged to M67:
https://webrtc-review.googlesource.com/c/src/+/75122
The NextAction date has arrived: 2018-05-08
Labels: -Merge-Merged -Merge-Approved-67 merge-merged-67
Per comment #8, this is already merged to M67.
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Comment 12 by peah@chromium.org, Jun 8 2018

Labels: M-67

Sign in to add a comment