AEC3: Suppressor too aggressive during double talk |
||||||||
Issue descriptionThe AEC3 suppressor sometimes acts more aggressively than needed. This affects transparency during double talk or when the far-end is leaking echo.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db2fcf631b675eca1c62d6d102a8108a928c51c2 commit db2fcf631b675eca1c62d6d102a8108a928c51c2 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 04 14:45:09 2018 Roll src/third_party/webrtc/ a1f566b28..9d96e9231 (14 commits) https://webrtc.googlesource.com/src.git/+log/a1f566b28a69..9d96e923169d $ git log a1f566b28..9d96e9231 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:839379,chromium:836790,chromium:839351,chromium:637666,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idaf4dcb114cbe96a981c6eba39aab8a3be42c19b Reviewed-on: https://chromium-review.googlesource.com/1044265 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556050} [modify] https://crrev.com/db2fcf631b675eca1c62d6d102a8108a928c51c2/DEPS
,
May 7 2018
,
May 7 2018
We would like this to be merged to M67. This code solves issues with transparency in AEC3 and fixes a regression in M67 where echo leakage in some cases could appear in the lower frequencies. This is a well tested fix that is currently part of Canary since three days. In the unlikely event of this code causing trouble, we have added a switch to be able to disable it remotely. CL to merge: https://webrtc-review.googlesource.com/c/src/+/73680
,
May 7 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 7 2018
Approvng merge for CL: https://webrtc-review.googlesource.com/c/src/+/73680 to M67 branch 3396 based on comment #4. Please merge ASAP so we can pick it up for this week beta Release. Thank you.
,
May 7 2018
,
May 8 2018
,
May 8 2018
The NextAction date has arrived: 2018-05-08
,
May 8 2018
Per comment #8, this is already merged to M67.
,
Jun 7 2018
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
,
Jun 8 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, May 4 2018