New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839376 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Auto-fills search input with login

Reported by jaco070...@gmail.com, May 3 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. login with jaco070489@gmail.com pass 070489
2. Remember login details
2. goto https://www.scorecapture.com/scorecapture/TeeOffTimes/ViewTeeOffTimes
3. Search input is populated with login email

What is the expected behavior?
input box should be empty

What went wrong?
input box is populated with login email

Did this work before? Yes 65

Does this work in other browsers? Yes

Chrome version: 66.0.3359.139  Channel: stable
OS Version: 10.0
Flash Version:
 
Components: UI>Browser>Autofill
Labels: Needs-Bisect Needs-Triage-M66
Cc: sindhu.chelamcherla@chromium.org manoranj...@chromium.org
Components: UI>Browser>Passwords
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable RegressedIn-66 M-66 FoundIn-66 Target-66 Triaged-ET OS-Linux OS-Mac Pri-1
Owner: dvadym@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 66.0.3359.139, on latest canary 68.0.3419.0 using Windows 10, Mac 10.12.6 and Ubuntu 17.10. Search box is autofilled with mail id after saving password. Hence providing bisect info

Good Build: 66.0.3335.0
Bad Build: 66.0.3336.0

You are probably looking for a change made after 533270 (known good), but no later than 533271 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/b1b678fa67398a5f77836cc9bf8dcfcb60e4420b..9c5823d6eabc57e8d9c95e4f08d2270ce853ca4f

Reviewed-on: https://chromium-review.googlesource.com/886707

Suspecting same from changelog.

@dvadym: Please confirm the bug and help in assigning to appropriate owner if this is not related to your change.. Adding RB-Stable for M-66. Please change if not the case.

Thanks!
Labels: Target-67 FoundIn-67 FoundIn-68 Target-68
Labels: M-67
*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/017745bc613504f1823d5cb1a0d5591a79e53f67

commit 017745bc613504f1823d5cb1a0d5591a79e53f67
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Tue May 08 14:20:45 2018

Revert "Do not skip password forms with multiple inputs with the same name."

This reverts of https://chromium-review.googlesource.com/c/chromium/src/+/886707.

The reason: it breaks Password Manager on almost any sites where
there are simultaneously fields with ids and without ids. Fixing this properly is
too difficult and risky for merging. And anyway processing of fields with empty
ids will be much improved in https://crbug.com/831123

Bug:  839376 , 803215

Change-Id: I91b535161335844266b0559b0ac21ecaf27faddc
Reviewed-on: https://chromium-review.googlesource.com/1049926
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556791}
[modify] https://crrev.com/017745bc613504f1823d5cb1a0d5591a79e53f67/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/017745bc613504f1823d5cb1a0d5591a79e53f67/components/autofill/content/renderer/password_autofill_agent.cc

Labels: Merge-Request-67
This CL is just a revert that returns status-quo that was before the original CL for years, so no risks. It fixes pretty visible incorrect behaviour of Password Manager.
Project Member

Comment 9 by sheriffbot@chromium.org, May 9 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
How is the revert listed at #7 looking in canary?
govind@ What do you mean by "looking in Canary"?

This CL is in Canary 68.0.3425.0 (which is built today).
Ok, is the revert verified in today's canary version 68.0.3425.0 and looks good to merge (didn't cause any regression)?
I've checked it in Canary, it looks good. The original CL was wrong, the state with the revert is better than without it.
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #8 and #13. Please merge ASAP. Thank you.
Also pls mark bug as fixed after M67 merge if nothing else is pending. Thank you.
*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Vadym, can you give me a list of sites that were affected by this so that we can track the behavior over time?
Project Member

Comment 18 by bugdroid1@chromium.org, May 11 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edf80dc6f3de6f21d541a43347ef9cb1a2ee53bf

commit edf80dc6f3de6f21d541a43347ef9cb1a2ee53bf
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Fri May 11 08:42:00 2018

Revert "Do not skip password forms with multiple inputs with the same name."

This reverts of https://chromium-review.googlesource.com/c/chromium/src/+/886707.

The reason: it breaks Password Manager on almost any sites where
there are simultaneously fields with ids and without ids. Fixing this properly is
too difficult and risky for merging. And anyway processing of fields with empty
ids will be much improved in https://crbug.com/831123

Bug:  839376 , 803215

TBR=dvadym@chromium.org

(cherry picked from commit 017745bc613504f1823d5cb1a0d5591a79e53f67)

Change-Id: I91b535161335844266b0559b0ac21ecaf27faddc
Reviewed-on: https://chromium-review.googlesource.com/1049926
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556791}
Reviewed-on: https://chromium-review.googlesource.com/1055387
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#565}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/edf80dc6f3de6f21d541a43347ef9cb1a2ee53bf/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/edf80dc6f3de6f21d541a43347ef9cb1a2ee53bf/components/autofill/content/renderer/password_autofill_agent.cc

Status: Fixed (was: Assigned)
battre@ I don't have much statistics. The original CL improved behaviour on  https://www.prioritypass.com bug 803215 (but it was still not ideal) and it breaks the site from this bug and very likely many other sites, since it made processing cases when fields have no ids pretty broken. So I believe that the best decision is to return back to the behaviour that was before.

It was unsuccessful attempt to make quick fix. We will fix problems with no ids in more systematic way after the current refactoring. I've blocked original bug with www.prioritypass.com on the refactoring bug. 
Hi Chromium Team

Not sure if this is the right place to ask but in what release is this fix expected to be rolled out?

Regards

It will be in version 67, which is currently in beta and it's going to stable in beginning of June.

Sign in to add a comment