New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839362 link

Starred by 3 users
Status: Duplicate
Merged: issue 838785
Owner:
vtsyrklevich@chromium.org
Closed: May 2018
Cc:
█ abdulsyed@chromium.org
ajha@chromium.org
█ sindhu.chelamcherla@chromium.org
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Crash is seen on clicking download link in crbug.com

Project Member Reported by sindhu.chelamcherla@chromium.org, May 3 2018 
Chrome Version: 68.0.3418.0
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1)Open any bug in crbug.com and click on download link of any attached files

Actual: Crash is seen on clicking download link
Expected: No crash should be seen and should be able to download file

This is a regression issue broken in M-68. Issue is not seen in Windows and Mac.

Good Build: 68.0.3415.0
Bad Build: 68.0.3416.0

You are probably looking for a change made after 554827 (known good), but no later than 554828 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/1fd3911f58d6b5696b4f212922b7260886156d68..a6889a090458a2653794c6e63387d6db743dc7f9

Reviewed-on: https://chromium-review.googlesource.com/1033918

Suspecting same from changelog.

@vtsyrklevich: Please confirm the bug and help in re-assigning if this is not related to your change. Adding RB-Stable for M-68. Please change if not the case.

Thanks!

Comment 1 by sindhu.chelamcherla@chromium.org, May 3 2018

Labels: -ReleaseBlock-Stable ReleaseBlock-Beta
Another repro case:

1. Right click on any link and select save link as option from context menu and observe -- browser crashes.

As this issue is seen on all links, changing blocker label to Beta. Please remove if not the case.

Thanks!

Comment 2 by ajha@chromium.org, May 3 2018

Cc: abdulsyed@chromium.org ajha@chromium.org ligim...@chromium.org
Labels: -ReleaseBlock-Beta RegressedIn-68 ReleaseBlock-Dev
Don't have stack trace to confirm but probably same as  Issue 839327 ,  Issue 838785  and Issue 838858.

Comment 4 by ligim...@chromium.org, May 3 2018

Mergedinto: 838785
Status: Duplicate (was: Assigned)

Comment 5 by vtsyrklevich@chromium.org, May 3 2018 

I've been unable to reproduce this with 68.0.3418.0 or a local build. Could you provide a stack trace when this crash occurs?

Comment 6 by vtsyrklevich@chromium.org, May 3 2018 

Nevermind, I managed to track it down from a crash report. The reason it didn't reproduce is that it was Unity-specific code.
Project Member

Comment 7 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12f5c3bf9d441834d3cbd16ed4ed1a0214cc3d91

commit 12f5c3bf9d441834d3cbd16ed4ed1a0214cc3d91
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Thu May 03 23:59:35 2018

CFI-icall: Blacklist dynamically resolved cross-DSO calls for Unity

BUG= 839362 , 838785 

Change-Id: I09528458d875c93e7c821c7789fc013f3f836b0a
Reviewed-on: https://chromium-review.googlesource.com/1043283
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555913}
[modify] https://crrev.com/12f5c3bf9d441834d3cbd16ed4ed1a0214cc3d91/tools/cfi/blacklist.txt

Comment 8 by sindhu.chelamcherla@chromium.org, May 4 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3418.2
Able to reproduce this issue on reported version hence verifying the fix on latest canary 68.0.3418.2 using Ubuntu 14.04.

Now clicking on download link or selecting save link as option no crash is seen. Attaching screencast for reference.

As fix is working as expected adding Verified labels. 

Thanks!
839362_68.0.3418.2.ogv
3.4 MB View Download

Comment 9 by sindhu.chelamcherla@chromium.org, May 4 2018 

NOTE: Issue is working fine in 68.0.3419.0 as well. No crash is seen on clicking links.

Thanks!
►

Sign in to add a comment