New issue
Advanced search Search tips

Issue 839351 link

Starred by 2 users
Status: Fixed
Owner:
w...@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Fuchsia SDK roll blocked on signed/unsigned comparison warnings->errors in WebRTC

Project Member Reported by w...@chromium.org, May 3 2018 
WebRTC has a couple of places where it checks that |int|s hold values in a 16-bit unsigned integer range.

Since the latest Fuchsia SDK builds remove the Fuchsia-specific stdint.h, we then build against the toolchain-provided stdint.h, in which UINT16MAX is actually uint16_t-typed, leading to a signed/unsigned comparison warning, which our builds treat as errors.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/939eb80ed0a563a2cd52516e254b4423b92c6413

commit 939eb80ed0a563a2cd52516e254b4423b92c6413
Author: Wez <wez@chromium.org>
Date: Fri May 04 08:21:44 2018

Add missing casts-to-int to int/uint16 comparisons.

These are required to avoid compilation errors due to signed/unsigned
comparison, on some toolchains (specifically Clang/Fuchsia).

Bug:  chromium:839351 
Change-Id: I52e726acd4e8d6744e98d7583bc82fcec81060d9
Reviewed-on: https://webrtc-review.googlesource.com/74100
Commit-Queue: Wez <wez@google.com>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23109}
[modify] https://crrev.com/939eb80ed0a563a2cd52516e254b4423b92c6413/media/base/rtputils.cc
[modify] https://crrev.com/939eb80ed0a563a2cd52516e254b4423b92c6413/pc/peerconnection.cc

Comment 2 by w...@chromium.org, May 4 2018

Status: Fixed (was: Started)
Next WebRTC roll should pick this up -> Fixed.
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db2fcf631b675eca1c62d6d102a8108a928c51c2

commit db2fcf631b675eca1c62d6d102a8108a928c51c2
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 04 14:45:09 2018

Roll src/third_party/webrtc/ a1f566b28..9d96e9231 (14 commits)

https://webrtc.googlesource.com/src.git/+log/a1f566b28a69..9d96e923169d

$ git log a1f566b28..9d96e9231 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:839379,chromium:836790,chromium:839351,chromium:637666,chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idaf4dcb114cbe96a981c6eba39aab8a3be42c19b
Reviewed-on: https://chromium-review.googlesource.com/1044265
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556050}
[modify] https://crrev.com/db2fcf631b675eca1c62d6d102a8108a928c51c2/DEPS
►

Sign in to add a comment