New issue
Advanced search Search tips

Issue 839349 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

crrev.com/c/1029177 might be causing release build failures

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 3 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of coconutruben@google.com

It seems that a recent refactor is causing build failures, as the script cannot locate the file anymore. I'm not sure if this is an issue of updating the builders, or configuration, or if there's a change we need to make to the CL. Gwendal, Hung-Te?

crrev.com/c/1029177

Builders failed on: 
- betty-arc64-release: 
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8947586681668484832
- betty-release: 
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8947586689482910000
- newbie-release: 
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8947586695682161184
- novato-arc64-release: 
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8947586717234253568
- novato-release: 
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8947586696070335008


 
Cc: -coconutruben@google.com gwendal@chromium.org coconutruben@chromium.org agicsaki@chromium.org warx@chromium.org hungte@chromium.org dgarr...@chromium.org henryhsu@chromium.org
Components: Infra>Client>ChromeOS
Labels: -Pri-2 Hotlist-CrOS-Sheriffing Pri-1
this is still causing failures.
crrev.com/c/1029177 renamed
installer/share/chromeos-common.sh to chromeos-common-script/share/chromeos-common.sh
inside https://cs.corp.google.com/chromeos_public/src/scripts/mount_gpt_image.sh?sq&q=mount_gpt_+package:%5Echromeos_public$&g=0&l=1
we call
if [[ $INSIDE_CHROOT -ne 1 ]]; then
  INSTALL_ROOT="$SRC_ROOT/platform2/installer/share"
else
  INSTALL_ROOT=/usr/share/misc
fi
# Load functions and constants for chromeos-install
. "${INSTALL_ROOT}/chromeos-common.sh" || exit 1

causing a failure as it cannot find the file. 

Owner: gwendal@chromium.org
Status: Started (was: Available)
gwendal has already made a fix in https://chromium-review.googlesource.com/c/chromiumos/platform/crosutils/+/1042852
chumped the change, let's see if this fixes the failures

Comment 5 by warx@chromium.org, May 7 2018

Cc: -warx@chromium.org -agicsaki@chromium.org malaykeshav@chromium.org sammiequon@chromium.org
Status: Fixed (was: Started)
seems good so far, marking as fixed

Sign in to add a comment