New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839320 link

Starred by 3 users
Status: Fixed
Owner:
jdufault@chromium.org
Closed: Aug 7
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
wzang@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression : 'Sorry your password..." Error message is seen on clicking 'Enter' button when no password is entered for User in Lock screen

Project Member Reported by mmanchala@chromium.org, May 3 2018 
Chrome Version: 68.0.3416.0/10642.0.0 dev-channel Peppy,Paine and Kip
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> click on Uber Tray and select 'Lock' option
(2)Now in Lock screen click on 'enter' button from keyboard and observe  'Sorry your password..."  Error message is seen i.e. without entering password for User, 'Enter' button is working and Error message is seen
(Please refer Video)


Expected: 'Sorry your password..."  Error message should not be seen  on clicking 'Enter' button when no password is entered for User
Actual: Instead  'Sorry your password..."  Error message is seen on clicking 'Enter' button when no password is entered for User

This is Regression Issue as same is working fine in M-63

@jdufault : Please confirm the issue

Note : Issue is also seen on M-64, M-65, M-66 and M-67
Actual_ErrorMessage.mp4
9.1 MB View Download
Expected_NoErrorMessageisSeen.mp4
8.1 MB View Download

Comment 1 by jdufault@chromium.org, May 16 2018

Labels: -M-68 M-69 ReleaseBlock-Stable

Comment 2 by jdufault@chromium.org, Aug 6

Labels: -M-69 M-70
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21cd56637c8689be7d5bb80ecc666e4593cbb2d7

commit 21cd56637c8689be7d5bb80ecc666e4593cbb2d7
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Aug 07 18:04:33 2018

cros: Do not allow password submit on empty password.

Tap to unlock still should work on an empty password, though.

Bug:  839320 
Change-Id: Id5fd17c9428ddc2b6823cd3c63a5f21aa486b860
Reviewed-on: https://chromium-review.googlesource.com/1164257
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581278}
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/login_screen_controller.cc
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/21cd56637c8689be7d5bb80ecc666e4593cbb2d7/ash/login/ui/login_password_view.h

Comment 5 by jdufault@chromium.org, Aug 7

Status: Fixed (was: Started)
►

Sign in to add a comment