New issue
Advanced search Search tips

Issue 839300 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: May 2018
Cc:
mattcary@chromium.org
chrome-trooper-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

gclient recurse git config failing on orderfile bot

Project Member Reported by mattcary@chromium.org, May 3 2018 
The orderfile bot is failing at a gclient recurse step. This is before any of the actual orderfile processing, so I think it's a problem with the bot setup. At least three consecutive builds have failed so it doesn't seem to be a flake.

This is preventing orderfile generation, which will have an impact on chrome android startup time.

Thank you!

A failing build: https://ci.chromium.org/buildbot/internal.client.clank/orderfile-clankium/8002

The failing step is gclient recurse (git config user.name). Sample logs from the failing step:

Traceback (most recent call last):
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 3187, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 3173, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 2117, in CMDrecurse
    progress=not options.no_progress)
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 1704, in RunOnDeps
    patch_refs=patch_refs)
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient_utils.py", line 1075, in run
    self.item.run(*self.args, **self.kwargs)
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 1020, in run
    self.ParseDepsFile(expand_vars=(command != 'flatten'))
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 894, in ParseDepsFile
    self.add_dependencies_and_close(deps_to_add, hooks_to_run)
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 906, in add_dependencies_and_close
    if dep.verify_validity():
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 530, in verify_validity
    sibling_url = sibling.LateOverride(sibling.url)
  File "/b/build_internal/scripts/slave/.recipe_deps/depot_tools/gclient.py", line 551, in LateOverride
    assert self.parsed_url == None or not self.should_process, self.parsed_url
AssertionError: https://chrome-internal.googlesource.com/clank/third_party/android_tools.git@1fd8592eaef14bbc7a312a60adb3389f87a4af24
step returned non-zero exit code: 1

Comment 1 by martiniss@chromium.org, May 3 2018

Owner: ehmaldonado@chromium.org
Status: Assigned (was: Untriaged)
That line hasn't been changed in 10 years: https://chromium.googlesource.com/chromium/tools/depot_tools/+blame/6c692edf010ce9e43737406c53f399b13631ac4f/gclient.py#551

Probably a misconfiguration of the gclient file? I don't know a ton about it myself.

I think this was added recently by Edward though.

Comment 2 by ehmaldonado@chromium.org, May 3 2018 

Taking a look.

The revision of depot_tools didn't change between the last green build and the first purple build. The change I made was to bot_update, which this recipe doesn't use, so that's unrelated as well.

And it doesn't look like .gclient or DEPS changed in between either...

Comment 3 by ehmaldonado@chromium.org, May 3 2018

Owner: ----
Status: WontFix (was: Assigned)
I triggered a build [1] and it got past those steps. I believe [2] fixed it.

[1] https://uberchromegw.corp.google.com/i/internal.client.clank/builders/orderfile-clankium/builds/8009
[2] https://chrome-internal.googlesource.com/clank/internal/apps.git/+/fbe9ad968a1cafc7c9c72852f5e8acb62f479db9

Comment 4 by mattcary@chromium.org, May 4 2018 

Thanks for looking into this!
►

Sign in to add a comment