New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839286 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Bottom Separator line is missing from 'Set as Default' info bar .

Reported by shruti.j...@etouch.net, May 3 2018

Issue description

Chrome version:68.0.3418.0 (Official Build) Revision	5319d9b60c08fee2ca45593c7a67688408ce5d73-refs/heads/master@{#555651}  (64-bit)

OS:Mac OS X(10.12.6,10.13.1,10.13.5)

Pre-condition:Set any other browser as default other than 'Google chrome'.

Steps to reproduce:
1.Launch chrome and navigate to chrome://flags.
2.Enable Flag'Use Views browser windows instead of Cocoa.'
3.observe the separator line between 'Set as Default' bar and chrome://flag page.

Actual Result:Separator line is missing between 'Set as Default' bar and chrome://flag . 
Expected Result:Separator line should be seen between 'Set as Default' bar and chrome://flag . 

This is regression issue broken in ‘M-67’ and providing per-revision bisect info below
Good Build:67.0.3393.0(Revision: 549378) 
Bad Build:67.0.3394.0(Revision:549695) 
You are probably looking for a change made after 549398 (known good), but no later than 549399 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/0e2e01d06ec304d9a9a014d8a6054ce448c4583c..2bdfe08c63d614a324b8de0907d09d5bf9d426e6

Suspecting:https://chromium.googlesource.com/chromium/src/+/2bdfe08c63d614a324b8de0907d09d5bf9d426e6

@Peter Kasting: Could you please help to reassign if your change is not the cause for this change.

Note :Issue is only  reproducible on MAC(10.12.6,10.13.1,10.13.5) OS.

Thank You!

 
ACTUAL_RESULT.mov
2.4 MB View Download
EXPECTED_RESULT.mov
2.0 MB View Download
Summary: Regression:Bottom Separator line is missing from 'Set as Default' info bar . (was: Regression:Separator line is missing between 'Set as Default' bar and chrome://flag . )
Update:

Actual Result:Bottom Separator line is missing from 'Set as Default' info bar .
Expected Result:Bottom Separator line should be seen in 'Set as Default' info bar .

thank You!
Cc: pkasting@chromium.org
Owner: ellyjo...@chromium.org
This was a views change, and by default Mac shouldn't have been using views.  Reporter, do you have MacViews enabled?

Elly, could you help figure out if this reproduces today in MacViews and non-MacViews?
#3: in the repro steps, they have "2.Enable Flag'Use Views browser windows instead of Cocoa.'"

I would be surprised if this repros in Cocoa but I can check there if you'd like.
Status: Fixed (was: Assigned)
This looks fine to me now. Fixed.

Sign in to add a comment