New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839277 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ scottchen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary blue focus ring moves to below links on History page on pressing ‘Tab’ key.

Reported by dchau...@etouch.net, May 3 2018 
Chrome Version: 68.0.3418.0 (Official Build) Revision	5319d9b60c08fee2ca45593c7a67688408ce5d73-refs/heads/master@{#555651}  (32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.5)

What steps will reproduce the problem?
1. Launch Chrome and navigate to few webpages so that history gets generated.
2. Go to chrome://history page and press ‘Tab’ key till focus reaches to first link.
3. Now again multiple times press ‘Tab’ key from keyboard and observe the blue focus ring.

Actual: Unnecessary focus moves to below links on history page on pressing ‘Tab’ key.
Expected: Focus should not move to below links on history page on pressing ‘Tab’ key.

This is a regression issue, broken in M-68 series, will soon update other info.

Kindly review the attached screen-cast for reference.
Actual_behavior.mov
2.8 MB View Download
Expected behavior.mov
4.1 MB View Download

Comment 1 by dchau...@etouch.net, May 3 2018

Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range for the above issue.

Good build: 68.0.3416.0 (Revision: 554962)
Bad build: 68.0.3417.0 (Revision: 555217)

Using the per-revision bisect providing the bisect results:
You are probably looking for a change made after 554976 (known good), but no later than 554977 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/6bc1d79a51206286987b6f19e59839ae5ee83507..0269bc118f3131166d0673bdcac2039c7e801fcc

Suspecting: https://chromium.googlesource.com/chromium/src/+/0269bc118f3131166d0673bdcac2039c7e801fcc

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank you.

Comment 2 by scottchen@chromium.org, May 3 2018

Cc: scottchen@chromium.org
 Issue 839267  has been merged into this issue.

Comment 3 by scottchen@chromium.org, May 3 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b97a3124170826d6e6d5fe48df5cfbfa4cff1db

commit 6b97a3124170826d6e6d5fe48df5cfbfa4cff1db
Author: Scott Chen <scottchen@chromium.org>
Date: Sat May 05 02:25:34 2018

WebUI[MD-refresh]: on init, cr-checkbox should not alter tabindex if not disabled.

When initializing, cr-checkbox unnecessarily set tabindex to 0 even if it
was set to something else. This CL fixes it

Bug:  839277 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I73d6e97ad7b6be8b7cd18759f1677f65acf96947
Reviewed-on: https://chromium-review.googlesource.com/1042864
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556293}
[modify] https://crrev.com/6b97a3124170826d6e6d5fe48df5cfbfa4cff1db/chrome/test/data/webui/cr_elements/cr_checkbox_test.js
[modify] https://crrev.com/6b97a3124170826d6e6d5fe48df5cfbfa4cff1db/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js

Comment 5 by scottchen@chromium.org, May 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment