New issue
Advanced search Search tips

Issue 839275 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in SkCanvas::getTotalMatrix

Project Member Reported by ClusterFuzz, May 3 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6631743634014208

Fuzzer: afl_paint_op_buffer_eq_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000040
Crash State:
  SkCanvas::getTotalMatrix
  cc::PaintOpBufferSerializer::SerializeBuffer
  cc::PaintOpWriter::Write
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=555636:555647

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6631743634014208

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 3 2018

Components: Internals>Compositing Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 3 2018

Cc: enne@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 3 2018

Labels: Test-Predator-Auto-Owner
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/a8d50641199fe8b3045a4615d877d7c341bf7724 (oop: Intergrate skia font remoting for OOP raster.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by ClusterFuzz, May 6 2018

Labels: OS-Mac

Comment 5 by hcm@chromium.org, May 10 2018

Components: -Internals>Skia
Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/694fc8b87c14ca162c353500625090bd6069ee0f

commit 694fc8b87c14ca162c353500625090bd6069ee0f
Author: Khushal <khushalsagar@chromium.org>
Date: Sat May 12 01:16:19 2018

cc: Ensure color space for SerializeOptions in TestOptionsProvider.

Also remove default ctors for Serialize and DeserializeOptions. Makes
it easier to ensure everything is plumbed through.

TBR=ericrk@chromium.org
R=enne@chromium.org

Bug:  839275 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia1dede6c7b87b77613dd778f67595fb7b5a8edab
Reviewed-on: https://chromium-review.googlesource.com/1049052
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558082}
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/paint/paint_op_reader.h
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/paint/paint_op_writer.h
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/test/test_options_provider.cc
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/cc/test/test_options_provider.h
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/694fc8b87c14ca162c353500625090bd6069ee0f/services/viz/public/cpp/compositing/paint_filter_struct_traits.cc

Project Member

Comment 7 by ClusterFuzz, May 12 2018

ClusterFuzz has detected this issue as fixed in range 558075:558089.

Detailed report: https://clusterfuzz.com/testcase?key=6631743634014208

Fuzzer: afl_paint_op_buffer_eq_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000040
Crash State:
  SkCanvas::getTotalMatrix
  cc::PaintOpBufferSerializer::SerializeBuffer
  cc::PaintOpWriter::Write
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=555636:555647
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=558075:558089

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6631743634014208

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, May 12 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6631743634014208 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment