New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839272 link

Starred by 3 users
Status: Assigned
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Opening app served from localhost shows location bar

Project Member Reported by mgiuca@chromium.org, May 3 2018 
Chrome Version: 66.0.3359.139
OS: Linux

(Needs to be confirmed on latest CrOS build, since this is a fairly out of date version.)

What steps will reproduce the problem?
(1) Serve a PWA from localhost (e.g., https://github.com/benfredwells/killer-marmot)
(2) Navigate to page.
(3) Install the PWA.
(4) Close it.
(5) Re-open it from chrome:apps / launcher.

What is the expected result?
No location bar, since it's still secure.

What happens instead?
Upon re-opening, it has a location bar.

Comment 1 by ortuno@chromium.org, May 3 2018 

Is this really a regression?

I'm wonder if we are showing the location bar because we don't recognize the scheme: https://cs.chromium.org/chromium/src/chrome/browser/ui/extensions/hosted_app_browser_controller.cc?type=cs&sq=package:chromium&l=47

Also for some reason we consider all navigations to be out of scope, but that's a separate issue.

Comment 2 by mgiuca@chromium.org, May 4 2018 

I think it probably regressed when I changed how we check for the location bar.

> Is this really a regression?

Do you mean was this previously working? Or is this really bad?

I think it is bad --- localhost should work just as well as any https site.

Comment 3 by ortuno@chromium.org, May 7 2018 

I forgot about your change to the scheme checking code, so I thought we always had this behavior.

Comment 4 by mgiuca@chromium.org, Jun 18 2018

Labels: -M-68 M-69
Bulk punting M68 PWA bugs to M69.

Comment 5 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
►

Sign in to add a comment